From owner-svn-src-head@freebsd.org Fri Aug 26 20:04:15 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19C5CB76C4C; Fri, 26 Aug 2016 20:04:15 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F0A422688; Fri, 26 Aug 2016 20:04:14 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id E02E81302; Fri, 26 Aug 2016 20:04:14 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6CF1F236F4; Fri, 26 Aug 2016 20:04:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 7op064J6FaW6; Fri, 26 Aug 2016 20:04:10 +0000 (UTC) Subject: Re: svn commit: r303988 - head/lib/libc/gen DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 8085C236EC To: John Baldwin , Ed Schouten References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <2038784.5k3koFGWFB@ralph.baldwin.cx> Cc: Guido Falsi , svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Schouten From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> Date: Fri, 26 Aug 2016 13:04:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2038784.5k3koFGWFB@ralph.baldwin.cx> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 20:04:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU Content-Type: multipart/mixed; boundary="g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG" From: Bryan Drewery To: John Baldwin , Ed Schouten Cc: Guido Falsi , svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Schouten Message-ID: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <2038784.5k3koFGWFB@ralph.baldwin.cx> In-Reply-To: <2038784.5k3koFGWFB@ralph.baldwin.cx> --g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/26/2016 12:57 PM, John Baldwin wrote: > On Friday, August 26, 2016 09:37:10 AM Ed Schouten wrote: >> Hi, >> >> 2016-08-26 1:52 GMT+02:00 Bryan Drewery : >>> Libc wouldn't build, it complained quite loudly with a lot of these: >> >> Got it. Thinking ahead, if it's just basename() giving the problems, >> maybe it's easier to just go ahead and bump the symver of basename() >> as well? I'm planning on replacing it anyway to be in sync with the >> new basename() anyway. Attached is a new patch. Be sure to let me know= >> whether that works for you. >=20 > Alternatively, couldn't you just leave basename out of the libgen patch= > for now and only add it once you do the real symver bump for the > different version? (That is, just use __generic() for dirname() for > now since that is the only one that has really changed.) >=20 Doing this also works. I think it was done since the prototype did change as well which disallows building the old xinstall directly, but in the bootstrap build it is built with MK_WARNS=3Dno so the error is ignored. > /usr/local/bin/ccache cc -O2 -pipe -I/root/svn/releng/11.0/usr.bin/xi= nstall/../../contrib/mtree -I/root/svn/releng/11.0/usr.bin/xinstall/../..= /lib/libnetbsd -g -std=3Dgnu99 -fstack-protector-strong -Qunused-argument= s -c /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c -o xinstall.o > /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c:696:17: warning: pass= ing 'const char *' to parameter of type 'char *' discards qualifiers [-Wi= ncompatible-pointer-types-discards-qualifiers] > cp =3D basename(to_name); > ^~~~~~~ > /usr/include/libgen.h:37:22: note: passing argument to parameter here > char *basename(char *); > ^ > 1 warning generated. > Building /usr/obj/root/svn/releng/11.0/usr.bin/xinstall/getid.o Let's just not forget to add the _generic in if/when needed too. --=20 Regards, Bryan Drewery --g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG-- --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXwKC6AAoJEDXXcbtuRpfP8SoH/1XFpL2oziQCdO7++oArRqVf IfkLtLSuHkwD1m9f8YgJTf9CK3ywi492DFWLFBSoQ+8bxx5Km8KLOIURJ3s0GTDl 4m5n1mRRLWqxU01YK+kfgBjd58koIIVyRQupwhavBfloqwF+6T/QA8j/i7PTJM7+ xKF8vLLAdH8HaDJGCdtHJLkL/RYuZhcWkNqerWLCRF6oq4LmmbCKJAgWEHAkC3Wi W+XFINQRqn9757I90Fqw4uesaG60Ljkce+iO4h7vX6VQs9wnvaWPBNInTGXvCNwN ssHqSttUaWxfHNQst1CkxunxgFGOrkBhSuEqJvmAc5A4Ok4YdiJbNB/YscpiRQU= =nuQs -----END PGP SIGNATURE----- --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU--