Date: Fri, 26 Aug 2016 13:04:10 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, Ed Schouten <ed@nuxi.nl> Cc: Guido Falsi <madpilot@freebsd.org>, svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen Message-ID: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> In-Reply-To: <2038784.5k3koFGWFB@ralph.baldwin.cx> References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com> <2038784.5k3koFGWFB@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU Content-Type: multipart/mixed; boundary="g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG" From: Bryan Drewery <bdrewery@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, Ed Schouten <ed@nuxi.nl> Cc: Guido Falsi <madpilot@freebsd.org>, svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Ed Schouten <ed@freebsd.org> Message-ID: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <CABh_MKnHa-djy_HVEGhCM8xAjOXwrhdP7Sh-Gr6v09nrbS5pnw@mail.gmail.com> <2038784.5k3koFGWFB@ralph.baldwin.cx> In-Reply-To: <2038784.5k3koFGWFB@ralph.baldwin.cx> --g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/26/2016 12:57 PM, John Baldwin wrote: > On Friday, August 26, 2016 09:37:10 AM Ed Schouten wrote: >> Hi, >> >> 2016-08-26 1:52 GMT+02:00 Bryan Drewery <bdrewery@freebsd.org>: >>> Libc wouldn't build, it complained quite loudly with a lot of these: >> >> Got it. Thinking ahead, if it's just basename() giving the problems, >> maybe it's easier to just go ahead and bump the symver of basename() >> as well? I'm planning on replacing it anyway to be in sync with the >> new basename() anyway. Attached is a new patch. Be sure to let me know= >> whether that works for you. >=20 > Alternatively, couldn't you just leave basename out of the libgen patch= > for now and only add it once you do the real symver bump for the > different version? (That is, just use __generic() for dirname() for > now since that is the only one that has really changed.) >=20 Doing this also works. I think it was done since the prototype did change as well which disallows building the old xinstall directly, but in the bootstrap build it is built with MK_WARNS=3Dno so the error is ignored. > /usr/local/bin/ccache cc -O2 -pipe -I/root/svn/releng/11.0/usr.bin/xi= nstall/../../contrib/mtree -I/root/svn/releng/11.0/usr.bin/xinstall/../..= /lib/libnetbsd -g -std=3Dgnu99 -fstack-protector-strong -Qunused-argument= s -c /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c -o xinstall.o > /root/svn/releng/11.0/usr.bin/xinstall/xinstall.c:696:17: warning: pass= ing 'const char *' to parameter of type 'char *' discards qualifiers [-Wi= ncompatible-pointer-types-discards-qualifiers] > cp =3D basename(to_name); > ^~~~~~~ > /usr/include/libgen.h:37:22: note: passing argument to parameter here > char *basename(char *); > ^ > 1 warning generated. > Building /usr/obj/root/svn/releng/11.0/usr.bin/xinstall/getid.o Let's just not forget to add the _generic in if/when needed too. --=20 Regards, Bryan Drewery --g0n8exE9J4WxKVWXKcF6QmfnFe5FGaAbG-- --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXwKC6AAoJEDXXcbtuRpfP8SoH/1XFpL2oziQCdO7++oArRqVf IfkLtLSuHkwD1m9f8YgJTf9CK3ywi492DFWLFBSoQ+8bxx5Km8KLOIURJ3s0GTDl 4m5n1mRRLWqxU01YK+kfgBjd58koIIVyRQupwhavBfloqwF+6T/QA8j/i7PTJM7+ xKF8vLLAdH8HaDJGCdtHJLkL/RYuZhcWkNqerWLCRF6oq4LmmbCKJAgWEHAkC3Wi W+XFINQRqn9757I90Fqw4uesaG60Ljkce+iO4h7vX6VQs9wnvaWPBNInTGXvCNwN ssHqSttUaWxfHNQst1CkxunxgFGOrkBhSuEqJvmAc5A4Ok4YdiJbNB/YscpiRQU= =nuQs -----END PGP SIGNATURE----- --q65JcBUlgJUhOsgnSILIIgjgHHNVML3uU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7faebb9e-897a-0a7e-0ec7-c599e8658095>