From owner-cvs-all Sat Dec 18 5:45:27 1999 Delivered-To: cvs-all@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id DD15A14D23; Sat, 18 Dec 1999 05:45:22 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost [127.0.0.1]) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id IAA74565; Sat, 18 Dec 1999 08:45:01 -0500 (EST) (envelope-from green@FreeBSD.org) Date: Sat, 18 Dec 1999 08:45:01 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen fts.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, 18 Dec 1999, Bruce Evans wrote: > On Fri, 17 Dec 1999, Brian Feldman wrote: > > > green 1999/12/17 20:47:29 PST > > > > Modified files: (Branch: RELENG_3) > > lib/libc/gen fts.c > > Log: > > MFC: rev.1.12 > > OpenBSD fts.c, including bug fixes for this gross piece of coding badness. > > > > Approved by: jkh > > Obtained from: OpenBSD > > Not approved by: bde. I don't even approve of the way it was changed in > -current (splatting the OpenBSD version on top of the FreeBSD version > without analyzing the differences in detail). What do you object to? In my analysis of the changes, I didn't notice anything bad. The only difference I can think of objecting to would be reversion to using realloc() instead of reallocf(), but the code works the same either way. Perhaps you could post the analysis of the changes you object to, then? > > Bruce > > > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message