From owner-svn-src-all@freebsd.org Wed Feb 27 04:17:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DBAB150F97E for ; Wed, 27 Feb 2019 04:17:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 202718BBF5 for ; Wed, 27 Feb 2019 04:17:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x841.google.com with SMTP id a48so17776477qtb.4 for ; Tue, 26 Feb 2019 20:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X0hLsD4DzO+ybSvEWm8CXZCpnMZdBxh+rETifCfDvo8=; b=bMg5WaNjSJsoJFyNSBRloJP5qShqJ3p1jl5wMHxP0ZvnI2HSX8dTV1A0wJu9GlxwZ+ GKfjY19YN65CRd817BHJ4JyHzby0B/RTWoJg2SAYFTw6j27szxXak46xE0sT7KnqKC05 8qqtYJo4NNKNcyz6SCJdCcYgiRbhIZmjsVC/+EWnYpcBmiaGXzgKLt1w7Mj4bOc3HdGd KleDDB9VwSAks3sCwlAKQuSQLkf577Pzbt3boMrpl13dENJeUq6pDGxroqZoO8uRRHsX qjhhuBf/AgPG5eXnkb2gxizeur0OtT/iMIA4Igo2S796atXV+xTHGl2LfSnVPUVmfDZI ceXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X0hLsD4DzO+ybSvEWm8CXZCpnMZdBxh+rETifCfDvo8=; b=GvfFDG1pv4OIcVq2YldHKWcnxet/M8mfR7tBg7gaKxnd0+PPixYNKwDx8RT33dytB+ DPcPjnPOpR7/IiSNerMQ38EM3qciBLgRCWWP5bA7UpykkrjXRocnYB6pOUhkuHsQ8TRZ 2azFY4/lUyiocSBEJVSAlWtglAxBgJ4xmYPmCVhRz4hFkJQVfMH75xzXt1NhOcXxOlwI 6q8FV7bvbei1IqV3XdVOxlffdqn8qAcOUBUt5hVKdFMeSeM/xa6vY+dUe0kNS9Uf7wdp axfkdhyh2qCJz/Y7jlPTa81QQTDMLIYIkgzA6h4tHH9nKLwsYFIAZ7cG5lu78dkWnEvX UhFA== X-Gm-Message-State: AHQUAua82iO7TjccyBDKaRfD6tRXrctIHJgs4yIUM9iaPeXqlHMMAeeN OSvX4EW/zI2crJWaw8shrUXiecV/dHVFw9kLQPUlTl78 X-Google-Smtp-Source: AHgI3Ib45eCcwadiYvjSaIEIwIwksFWcd9+2dzgWgsLBhOZVf2dzP9Oq2e6jImglgiYAMdGGFXoJI1J/+OgnF4vyh6U= X-Received: by 2002:ac8:35f8:: with SMTP id l53mr77668qtb.15.1551241040488; Tue, 26 Feb 2019 20:17:20 -0800 (PST) MIME-Version: 1.0 References: <201902260617.x1Q6HOra098699@repo.freebsd.org> <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net> <20190226134953.GB39566@FreeBSD.org> In-Reply-To: <20190226134953.GB39566@FreeBSD.org> From: Warner Losh Date: Tue, 26 Feb 2019 21:17:08 -0700 Message-ID: Subject: Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec To: Alexey Dokuchaev Cc: "Rodney W. Grimes" , "Simon J. Gerraty" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-Rspamd-Queue-Id: 202718BBF5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.941,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 04:17:21 -0000 On Tue, Feb 26, 2019, 6:50 AM Alexey Dokuchaev wrote: > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > > Author: sjg > > > Date: Tue Feb 26 06:17:23 2019 > > > New Revision: 344567 > > > URL: https://svnweb.freebsd.org/changeset/base/344567 > > > > > > Log: > > > Add verifying manifest loader for mac_veriexec > > > > > > This tool will verify a signed manifest and load contents into > > > mac_veriexec for storage > > > > > > Sponsored by: Juniper Networks > > > Differential Revision: D16575 > > > > Just a small nit, for future reference, from the template: > > > Differential Revision: https://reviews.freebsd.org/D### > > (*full* phabric URL needed). > > IMHO we should just fix the scripts to accept D#### alone, without > the URL. We don't do that for PR (bugzilla) references, and the fact > that we do for the phab is both needless and confusing. Also, that > URL might change one day while we could probably keep the old numbers > if we move. When this came up before, it was an upstream decision to require the full path. The reasoning is that Dxxxx space isn't unique and the review may happen in a different instance of phab than the default one. When those exact objections were raised, the experience of moving to bugzilla was cited to show the URL can remain stable. And if we went to another system's, we could keep the old in place and then we would need a new URL to disambiguate. There were good reasons we decided this before. So this has been litigated before, and the consensus was we needed to break with the practice of not putting URLs in commit messages for these reasons. Warner >