From owner-freebsd-current@FreeBSD.ORG  Tue Jun 18 23:51:42 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C8A91C4E;
 Tue, 18 Jun 2013 23:51:42 +0000 (UTC)
 (envelope-from oliver.pntr@gmail.com)
Received: from mail-oa0-x235.google.com (mail-oa0-x235.google.com
 [IPv6:2607:f8b0:4003:c02::235])
 by mx1.freebsd.org (Postfix) with ESMTP id 8DEC41B38;
 Tue, 18 Jun 2013 23:51:42 +0000 (UTC)
Received: by mail-oa0-f53.google.com with SMTP id k14so5709222oag.40
 for <multiple recipients>; Tue, 18 Jun 2013 16:51:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=32vYrU9I5Pyu4CUA/O3yFaPTsOgX+b38rBVEBSHw5no=;
 b=KcZ+ZnZFkP7ztEl/sPWdk9z16jmvK9E2E3fVHY9q324fH65BfoFf3i5LJA1hXFg4cy
 GuoDqpwpf2gh+Wo15KhFnYCtk2btmQhtfTbn2vEV6R5Bh7LWWbbojWq7InbZXQXiJkJA
 R9vovD77trlYDKlVUuprqnKRyTbGUcNcWe3PHuLoYjcqF/F7EjEWuZgSVY/bdNMhTkar
 MG0geCaKUuIyJyPprVqN8MkdrubmhOW9+vFATcNGSziPEgTxStCz190O36r5Atgx4iQq
 0X0vjrOQTxj++0TOcsZsKeql1Pm/iNC52MEwp8HPWbJFii8tNXm4byCVXdXTWi7dQH3F
 w+Zg==
MIME-Version: 1.0
X-Received: by 10.60.55.10 with SMTP id n10mr211525oep.45.1371599502208; Tue,
 18 Jun 2013 16:51:42 -0700 (PDT)
Received: by 10.182.227.231 with HTTP; Tue, 18 Jun 2013 16:51:42 -0700 (PDT)
In-Reply-To: <51C0EA9C.5090502@marino.st>
References: <CAPjTQNF9wW2=xwzMiWMFrodW6P37y58mZ6M7qM-ZiNKzykDNFw@mail.gmail.com>
 <51C0EA9C.5090502@marino.st>
Date: Wed, 19 Jun 2013 01:51:42 +0200
Message-ID: <CAPjTQNEEX187_tmqM5vSWBS4WM1ihXcBL=P5MuG76GDwD8DU2A@mail.gmail.com>
Subject: Re: gccmakedep fix - 20130619
From: Oliver Pinter <oliver.pntr@gmail.com>
To: John Marino <dragonflybsd@marino.st>
Content-Type: text/plain; charset=ISO-8859-1
Cc: ports@freebsd.org, current@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jun 2013 23:51:42 -0000

On 6/19/13, John Marino <dragonflybsd@marino.st> wrote:
> On 6/19/2013 01:00, Oliver Pinter wrote:
>> Hi all!
>>
>> Attached a fix to gccmakedep.
>
>
> So....
> 1) There's already multiple PRs on this, including one I just submitted:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=179571
>
> 2) Your patch adds an ".endif" which is already there
Hmm.. now I checked in github too:
https://github.com/freebsd/freebsd-ports/blob/master/devel/gccmakedep/Makefile
. Sure. Then my local git repo was broken.

>
> 3) Is not it better to submit via PR (GNATS) rather than a mailing list?
>   That's what PRs are for...

Mail are faster than PR-s.

>
> John
>
>