From owner-cvs-all Sat Sep 15 17:16:39 2001 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id CB93C37B405; Sat, 15 Sep 2001 17:16:34 -0700 (PDT) Received: (from dillon@localhost) by earth.backplane.com (8.11.6/8.11.2) id f8G0GY429697; Sat, 15 Sep 2001 17:16:34 -0700 (PDT) (envelope-from dillon) Date: Sat, 15 Sep 2001 17:16:34 -0700 (PDT) From: Matt Dillon Message-Id: <200109160016.f8G0GY429697@earth.backplane.com> To: "David O'Brien" Cc: Bruce Evans , freebsd-hackers@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libatm atm_addr.c cache_key.c ioctl_subr.c ip_addr.c ip_checksum.c timer.c References: <200109151939.f8FJdKF28278@earth.backplane.com> <20010916062557.V30137-100000@delplex.bde.org> <20010915170831.A84246@dragon.nuxi.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :What about changing this to __FBSD(), which is what I was using in a :prototype to reduce the number of characters in the macro name (and thus :reduce the wrap around). : :-- :-- David (obrien@FreeBSD.org) __FBSD() is too generic for a #define name in what is essentially a global header file. These are rcs id's, so it should be something like __FBSDID() or __FBSD_ID() or something like that, not just __FBSD(). -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message