From owner-freebsd-audit  Wed Jul 18  8: 5: 6 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP id BAAE837B408
	for <audit@FreeBSD.org>; Wed, 18 Jul 2001 08:05:03 -0700 (PDT)
	(envelope-from mike@coffee.q9media.com)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.2) id f6IFLgQ52914;
	Wed, 18 Jul 2001 11:21:42 -0400 (EDT)
	(envelope-from mike)
Date: Wed, 18 Jul 2001 11:21:42 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Peter Pentchev <roam@orbitel.bg>
Cc: Alexey Zelkin <phantom@FreeBSD.org.ua>, audit@FreeBSD.org,
	Dag-Erling Smorgrav <des@ofug.org>
Subject: Re: whois(1) changes
Message-ID: <20010718112142.B52720@coffee.q9media.com>
References: <20010717214524.A51455@coffee.q9media.com> <20010718154425.A65945@phantom.cris.net> <20010718110051.A52720@coffee.q9media.com> <20010718175637.D29731@ringworld.oblivion.bg>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010718175637.D29731@ringworld.oblivion.bg>; from roam@orbitel.bg on Wed, Jul 18, 2001 at 05:56:37PM +0300
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Wed, Jul 18, 2001 at 05:56:37PM +0300, Peter Pentchev wrote:
> On Wed, Jul 18, 2001 at 11:00:51AM -0400, Mike Barcroft wrote:
> > On Wed, Jul 18, 2001 at 03:44:25PM +0300, Alexey Zelkin wrote:
> > > 1. isdigit()'s argument should be explicitly casted to 'unsigned char' per
> > > ache's guidelines.
> > 
> > Can you explain this in more detail?  To my understanding, one only does
> > this when using setlocale(3) and friends.
> 
> It's only the sane thing to do.
> 
> Someone, some day, may decide to go ahead and make whois(1) locale-aware.
> You might as well make their job easier by using (logically correct)
> unsigned char arguments to functions that accept characters as opposed
> to arbitrary integer values.

That sounds reasonable.  I'll add the cast before committing.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message