Date: Wed, 18 Jul 2001 11:21:42 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Peter Pentchev <roam@orbitel.bg> Cc: Alexey Zelkin <phantom@FreeBSD.org.ua>, audit@FreeBSD.org, Dag-Erling Smorgrav <des@ofug.org> Subject: Re: whois(1) changes Message-ID: <20010718112142.B52720@coffee.q9media.com> In-Reply-To: <20010718175637.D29731@ringworld.oblivion.bg>; from roam@orbitel.bg on Wed, Jul 18, 2001 at 05:56:37PM %2B0300 References: <20010717214524.A51455@coffee.q9media.com> <20010718154425.A65945@phantom.cris.net> <20010718110051.A52720@coffee.q9media.com> <20010718175637.D29731@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2001 at 05:56:37PM +0300, Peter Pentchev wrote: > On Wed, Jul 18, 2001 at 11:00:51AM -0400, Mike Barcroft wrote: > > On Wed, Jul 18, 2001 at 03:44:25PM +0300, Alexey Zelkin wrote: > > > 1. isdigit()'s argument should be explicitly casted to 'unsigned char' per > > > ache's guidelines. > > > > Can you explain this in more detail? To my understanding, one only does > > this when using setlocale(3) and friends. > > It's only the sane thing to do. > > Someone, some day, may decide to go ahead and make whois(1) locale-aware. > You might as well make their job easier by using (logically correct) > unsigned char arguments to functions that accept characters as opposed > to arbitrary integer values. That sounds reasonable. I'll add the cast before committing. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010718112142.B52720>