From owner-freebsd-current@FreeBSD.ORG  Mon Jun  9 03:39:33 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D9BF837B418
	for <current@freebsd.org>; Mon,  9 Jun 2003 03:39:30 -0700 (PDT)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au
	[210.50.30.52])	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F2EF43FDD
	for <current@freebsd.org>; Mon,  9 Jun 2003 03:39:30 -0700 (PDT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au (210.50.202.200) by
	smtp01.syd.iprimus.net.au (7.0.015)
	id 3EDD516E00117568; Mon, 9 Jun 2003 20:39:25 +1000
Received: by dilbert.robbins.dropbear.id.au (Postfix, from userid 1000)
	id 61864C911; Mon,  9 Jun 2003 20:33:55 +1000 (EST)
Date: Mon, 9 Jun 2003 20:33:55 +1000
From: Tim Robbins <tjr@FreeBSD.ORG>
To: Donn Miller <dmmiller@cvzoom.net>
Message-ID: <20030609203355.A51153@dilbert.robbins.dropbear.id.au>
References: <3EE43394.6090802@cvzoom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <3EE43394.6090802@cvzoom.net>;
	from dmmiller@cvzoom.net on Mon, Jun 09, 2003 at 03:13:24AM -0400
cc: current@freebsd.org
Subject: Re: panic: mdconfig on an iso file mounted on smbfs
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jun 2003 10:39:34 -0000

On Mon, Jun 09, 2003 at 03:13:24AM -0400, Donn Miller wrote:

> Please see the attached gdb file.  I get this panic if I have a samba 
> filesystem mounted via mount_smbfs, where an iso file resides.  When I 
> try to use mdconfig on the file, I get an immediate panic.  The exact 
> mdconfig command issued is:
> 
> mount -a -t vnode -f /smbfs/sol-9-u3-x86-v1.iso -u 0

Try this patch and let me know whether it works. It seems to fix the problem
for me, but it still panics if I try to reboot the machine without running
mdconfig -d first.

--- sys/netsmb/smb_iod.c.orig	Mon Jun  9 20:36:56 2003
+++ sys/netsmb/smb_iod.c	Mon Jun  9 20:36:27 2003
@@ -400,7 +400,8 @@
 	int error;
 
 	SMBIODEBUG("\n");
-	if (rqp->sr_cred->scr_td->td_proc == iod->iod_p) {
+	if (rqp->sr_cred->scr_td != NULL &&
+	    rqp->sr_cred->scr_td->td_proc == iod->iod_p) {
 		rqp->sr_flags |= SMBR_INTERNAL;
 		SMB_IOD_RQLOCK(iod);
 		TAILQ_INSERT_HEAD(&iod->iod_rqlist, rqp, sr_link);