From owner-freebsd-ports@FreeBSD.ORG Tue Sep 17 16:05:27 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 877CAB74 for ; Tue, 17 Sep 2013 16:05:27 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1D06E2EF0 for ; Tue, 17 Sep 2013 16:05:26 +0000 (UTC) Received: by mail-ea0-f173.google.com with SMTP id g10so2838618eak.4 for ; Tue, 17 Sep 2013 09:05:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=kfM8xl2HjzNHQpQm7vcsyzWRTObWEq/uPhI9nVID0kk=; b=Gyh+A/cRbnFSwuDM/vBkd5spc/mJ15V/bbMhX9ZGGkevhcIKLE6fnPk+t4EK3FRrhJ O7qXs0uwhUUqtT5OzoiexXgdrQ2QS1jQhKT3f/YRoxSbOKzmUAtKLXCwMi7BLax1WhI4 /50zVhyeLo+CUVBl+aWQc4dy1lY1J16nyP5UHvjU1vOEInX5Sc1Bmbi+Of2AYdr0832F doJsrjAiU47vUD53ABCu385a8iiZCvfOC/ihnZPFsk4RBNKjZN1Lf8Xd1iNFOrApgrXU 0vK7YhapI1sopIZhfUgDdSMCGJR6XndtM9xrP0yXddAuW2Xasxh8RYIHzMRc46VuiWu+ fJIA== X-Gm-Message-State: ALoCoQn6s06IKaeczRpygRfCFOo1f7A3w1aRs+FYtT93OqmbKBoqBYbb2ZhK8LR1bmrY37JfZs06 MIME-Version: 1.0 X-Received: by 10.14.3.197 with SMTP id 45mr34116eeh.137.1379433599403; Tue, 17 Sep 2013 08:59:59 -0700 (PDT) Received: by 10.14.37.6 with HTTP; Tue, 17 Sep 2013 08:59:59 -0700 (PDT) In-Reply-To: <20130910010526.2a6aff37@thor.walstatt.dyndns.org> References: <20130909223748.61dd8859@thor.walstatt.dyndns.org> <20130910000237.6b5604da@nonamehost.local> <20130909231713.34ebfbdd@thor.walstatt.dyndns.org> <20130910002405.4aa701d0@nonamehost.local> <20130910004240.70bc281f@thor.walstatt.dyndns.org> <1378766963.1111.579.camel@revolution.hippie.lan> <20130910010526.2a6aff37@thor.walstatt.dyndns.org> Date: Tue, 17 Sep 2013 17:59:59 +0200 Message-ID: Subject: Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0); From: Olivier Smedts To: "O. Hartmann" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Ivan Klymenko , FreeBSD CURRENT , FreeBSD Ports , Ian Lepore X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 16:05:27 -0000 Hello, 2013/9/10 O. Hartmann > Yes, you're correct and my face is red like a tomatoe :-( > > I try this sed replacement expression: > sed -i -e '/\&virtual_address\, size\, \ > VMFS_ANY\_SPACE\,$/s//\&virtual_address\, size\, 0\, \ > VMFS_ANY\_SPACE\,/g' work/NVIDIA-FreeBSD-x86_64-325.15/src/nvidia_subr.c > > It works from the command line, but it doesn't work from the (attached) > Makefile-patch. > A little bit late here (I see a patch has been commited to x11/nvidia-driver/Makefile, with a shorter sed expression) but your problems seems to come from make interpreting "$". The "$/" variable is null, it's stripped from the sed expression which becomes invalid. You should escape the "$" inside the sed expression by doubling it. Cheers -- Olivier Smedts _ ASCII ribbon campaign ( ) e-mail: olivier@gid0.org - against HTML email & vCards X www: http://www.gid0.org - against proprietary attachments / \ "Il y a seulement 10 sortes de gens dans le monde : ceux qui comprennent le binaire, et ceux qui ne le comprennent pas."