From owner-freebsd-bugs@freebsd.org Tue Sep 1 12:16:51 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6C4D33C581C for ; Tue, 1 Sep 2020 12:16:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BgmJz2CFgz4R9f for ; Tue, 1 Sep 2020 12:16:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4BAD53C581B; Tue, 1 Sep 2020 12:16:51 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B7543C581A for ; Tue, 1 Sep 2020 12:16:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BgmJz0mBfz4RFx for ; Tue, 1 Sep 2020 12:16:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F199B18FB3 for ; Tue, 1 Sep 2020 12:16:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 081CGoKM080321 for ; Tue, 1 Sep 2020 12:16:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 081CGopC080320 for bugs@FreeBSD.org; Tue, 1 Sep 2020 12:16:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 249050] if_qlxgb mtu not initialized bug causing wrong pkt 0x62 dump start Date: Tue, 01 Sep 2020 12:16:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: novacrash_@hotmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 12:16:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D249050 Bug ID: 249050 Summary: if_qlxgb mtu not initialized bug causing wrong pkt 0x62 dump start Product: Base System Version: 12.1-STABLE Hardware: amd64 OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: novacrash_@hotmail.com Created attachment 217690 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D217690&action= =3Dedit Fix that mtu not initialized bug ql1: qla_pci_attach: firmware[4.20.1.1429931003] ql1: Ethernet address: 8c:dc:d4:59:c1:6c ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql1: link state changed to UP ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01 ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05 ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 05 ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01 ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05 ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 0a ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql1: qla_hw_send: (nsegs[1, 42, 0x0] > Q8_TX_MAX_SEGMENTS) ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x2a dump start ql1: 0x00000000: ff ff ff ff ff ff 8c dc d4 59 c1 6c 08 06 00 01 ql1: 0x00000010: 08 00 06 04 00 01 8c dc d4 59 c1 6c c0 a8 c8 05 ql1: 0x00000020: 00 00 00 00 00 00 c0 a8 c8 0a ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end ql1: qla_hw_send: (nsegs[1, 98, 0x0] > Q8_TX_MAX_SEGMENTS) ql1: qla_dump_buf8: qla_hw_send: wrong pkt 0x62 dump start ql1: 0x00000000: 90 e2 ba eb 01 68 8c dc d4 59 c1 6c 08 00 45 00 ql1: 0x00000010: 00 54 37 be 00 00 40 01 31 8a c0 a8 c8 05 c0 a8 ql1: 0x00000020: c8 0a 08 00 22 30 22 19 00 01 5a 94 07 ae 00 00 ql1: 0x00000030: 66 70 08 09 0a 0b 0c 0d 0e 0f 10 11 12 13 14 15 ql1: 0x00000040: 16 17 18 19 1a 1b 1c 1d 1e 1f 20 21 22 23 24 25 ql1: 0x00000050: 26 27 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33 34 35 ql1: 0x00000060: 36 37 ql1: qla_dump_buf8: qla_hw_send: wrong pkt dump end MTU need to be initialized before qla_os:685 ha->max_frame_size =3D ifp->if_mtu + ETHER_HDR_LEN + ETHER_CRC_LEN; Otherwise packet is always flagged as too big in qla_hw.c:1003 if ((mp->m_pkthdr.len > ha->max_frame_size)||(nsegs > Q8_TX_MAX_SEGMENTS)) { I also moved qla_os:694 ifp->if_capabilities =3D IFCAP_LINKSTATE; Before qla_os:687 ether_ifattach(ifp, qla_get_mac_addr(ha)); Like in qlxgbe/ql_os:877 because I had trouble doing ifconfig ql0 up for bridge. --=20 You are receiving this mail because: You are the assignee for the bug.=