From owner-cvs-all Thu Jan 30 15:36:43 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0206737B401; Thu, 30 Jan 2003 15:36:42 -0800 (PST) Received: from smtp04.iprimus.com.au (smtp04.iprimus.com.au [210.50.76.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAB1543E4A; Thu, 30 Jan 2003 15:36:40 -0800 (PST) (envelope-from tim@robbins.dropbear.id.au) Received: from smtp01.iprimus.net.au (210.50.30.70) by smtp04.iprimus.com.au (6.7.010) id 3E3608DE0009F9F0; Fri, 31 Jan 2003 10:36:33 +1100 Received: from dilbert.robbins.dropbear.id.au ([203.134.135.121]) by smtp01.iprimus.net.au with Microsoft SMTPSVC(5.0.2195.5600); Fri, 31 Jan 2003 10:36:32 +1100 Received: from dilbert.robbins.dropbear.id.au (goi1o4d27g1a2gh7@localhost [127.0.0.1]) by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id h0UNaM7i051083; Fri, 31 Jan 2003 10:36:22 +1100 (EST) (envelope-from tim@dilbert.robbins.dropbear.id.au) Received: (from tim@localhost) by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id h0UNaLXP051082; Fri, 31 Jan 2003 10:36:21 +1100 (EST) (envelope-from tim) Date: Fri, 31 Jan 2003 10:36:21 +1100 From: Tim Robbins To: "Jacques A. Vidrine" , "M. Warner Losh" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdio gets.c Message-ID: <20030131103621.A50979@dilbert.robbins.dropbear.id.au> References: <200301301200.h0UC0Qfd081080@repoman.freebsd.org> <20030130.063524.24235010.imp@bsdimp.com> <20030131092613.A48425@dilbert.robbins.dropbear.id.au> <20030130230217.GA75768@opus.celabo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030130230217.GA75768@opus.celabo.org>; from nectar@FreeBSD.ORG on Thu, Jan 30, 2003 at 05:02:17PM -0600 X-OriginalArrivalTime: 30 Jan 2003 23:36:33.0116 (UTC) FILETIME=[6BFE49C0:01C2C8B8] Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jan 30, 2003 at 05:02:17PM -0600, Jacques A. Vidrine wrote: > On Fri, Jan 31, 2003 at 09:26:13AM +1100, Tim Robbins wrote: > > On Thu, Jan 30, 2003 at 06:35:24AM -0700, M. Warner Losh wrote: > > > > > In message: <200301301200.h0UC0Qfd081080@repoman.freebsd.org> > > > "Tim J. Robbins" writes: > > > : tjr 2003/01/30 04:00:26 PST > > > : > > > : Modified files: > > > : lib/libc/stdio gets.c > > > : Log: > > > : Remove runtime warning about gets(). > > > > > > Why? > > > > Because it's tacky, redundant (we already warn at compile time) > > and not worth the space. NetBSD and BSD/OS removed it years ago. > > > > If you disagree and would like me to back this out, tell me. > > I don't feel strongly enough about this to argue. > > I'd like it backed out, but also find it hard to argue vehemently. It > may be tacky, but so what --- applications should never use gets(). > I don't find it redundant ... it is easy to miss warnings at compile > time yet this is a very dangerous function. I'd be happy to see it > removed from libc, to be honest, if ISO C didn't require it. That's all it takes. I've backed out the removal of the warning. [sound of worms being forced back into the can] Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message