From owner-svn-src-all@freebsd.org Thu Jun 18 00:48:25 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A089333C540; Thu, 18 Jun 2020 00:48:25 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49nNbF2M65z3WvB; Thu, 18 Jun 2020 00:48:25 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi1-f194.google.com with SMTP id b8so3555764oic.1; Wed, 17 Jun 2020 17:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=0km25gL505Ui7+zDolzn2LXI1AJSiJQaZsTA3Y0do/A=; b=aQWIq2YhSdM/tc0BZAD/kVY7AtrwYMNNWnvpJzuhwNhGFUK/xFD7AE4RQqGjU8Yp7v 6Yzb2/2rHF94s6jaKqJYDZaskCAOqcXh47fqZcDh9q9j7I5gR/DUFTskfMTYEywCkL6j SAyWcHO8E3Yy5J0jhad86xrs3JPwAp3FvLLAQbRz6DB20G5bH0dYTSSSfiIMi2+8vM9t l/EDhbHW5fliwuMsTumPVH2ZnyE6H0I/jnnu8qkFIIedGyCQ6aPksjdxfSlHOw8uVIn3 Ob98V5FB5drGrmmP09X5r4h7OpqeiJp1MGkntYh/hOmyrlO3i5RaSPshqZDcGd9yFp1Y upog== X-Gm-Message-State: AOAM531hP1Yv8Mcfk9UOdi22xjpb/+TKUgLnXFXORmd5+n7zTKEwMdRI 2boBtB1fhnm8ZjKs/6d8SaHegrxL X-Google-Smtp-Source: ABdhPJydYELtMJhS8AFFD0HZArK9n7F2W6Al25bW1lMbjP/qswReTe/3MDBwIU0TJtH8ti7HlSgvzw== X-Received: by 2002:aca:4ec3:: with SMTP id c186mr1066215oib.64.1592441304027; Wed, 17 Jun 2020 17:48:24 -0700 (PDT) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com. [209.85.210.45]) by smtp.gmail.com with ESMTPSA id j46sm372827ota.69.2020.06.17.17.48.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 17:48:23 -0700 (PDT) Received: by mail-ot1-f45.google.com with SMTP id k15so3195998otp.8; Wed, 17 Jun 2020 17:48:23 -0700 (PDT) X-Received: by 2002:a05:6830:18da:: with SMTP id v26mr1443358ote.135.1592441303644; Wed, 17 Jun 2020 17:48:23 -0700 (PDT) MIME-Version: 1.0 References: <202006122153.05CLr8JN091722@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 17 Jun 2020 17:48:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r362126 - head/sys/vm To: John Baldwin Cc: Eric van Gyzen , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49nNbF2M65z3WvB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 00:48:25 -0000 On Wed, Jun 17, 2020 at 10:50 AM John Baldwin wrote: > > On 6/12/20 3:33 PM, Conrad Meyer wrote: > > On Fri, Jun 12, 2020 at 2:53 PM Eric van Gyzen wrote: > >> Honor db_pager_quit in some vm_object ddb commands > >> > >> These can be rather verbose. > > > > We also have this (?)hack in OneFS, which eliminates the need for > > every debug function to check the db_pager globals: > > > > https://people.freebsd.org/~cem/db_pager.patch > > > > I'm not sure how objectionable it is. > > I don't think this addresses that. I think this patch makes printf turn > into db_printf when a function is invoked from DDB which is orthogonal. > db_printf() itself doesn't check the pager. db_printf checks the pager, via db_putc.