From owner-svn-src-head@freebsd.org  Fri Aug  3 22:27:41 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABAF1105363C;
 Fri,  3 Aug 2018 22:27:41 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [198.45.61.253])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2E768784B9;
 Fri,  3 Aug 2018 22:27:41 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w73MRdNR062807
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 3 Aug 2018 15:27:39 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id w73MRdTT062806;
 Fri, 3 Aug 2018 15:27:39 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Fri, 3 Aug 2018 15:27:39 -0700
From: Gleb Smirnoff <glebius@freebsd.org>
To: Konstantin Belousov <kib@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r336047 - in head/sys: amd64/include i386/include sys
Message-ID: <20180803222739.GH420@FreeBSD.org>
References: <201807061950.w66Joibw081390@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201807061950.w66Joibw081390@repo.freebsd.org>
User-Agent: Mutt/1.10.0 (2018-05-17)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2018 22:27:41 -0000

  Hi Konstantin,

On Fri, Jul 06, 2018 at 07:50:44PM +0000, Konstantin Belousov wrote:
K> Author: kib
K> Date: Fri Jul  6 19:50:44 2018
K> New Revision: 336047
K> URL: https://svnweb.freebsd.org/changeset/base/336047
K> 
K> Log:
K>   Expand x86 struct pcpus to UMA_PCPU_ALLOC_SIZE AKA PAGE_SIZE.
K>   
K>   This restores counters(9) operation.
K>   Revert r336024. Improve assert of pcpu size on x86.
K>   
K>   Reviewed by:	mmacy
K>   Sponsored by:	The FreeBSD Foundation
K>   Differential revision:	https://reviews.freebsd.org/D16163

Since this has been broken already several times as people who edit
surrounding code don't understand the magic, and since now we round
the struct pcpu size to PAGE_SIZE anyways, what about stop carefully
craft the padding and just change alignment of struct pcpu to PAGE_SIZE?

-- 
Gleb Smirnoff