From owner-freebsd-bugs@freebsd.org  Tue Feb  2 18:20:51 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44315A995FF
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  2 Feb 2016 18:20:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 341899BE
 for <freebsd-bugs@FreeBSD.org>; Tue,  2 Feb 2016 18:20:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u12IKoHk037583
 for <freebsd-bugs@FreeBSD.org>; Tue, 2 Feb 2016 18:20:51 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 206573] Improper userland pointer handling in aacraid
Date: Tue, 02 Feb 2016 18:20:50 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: misc
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: needs-qa, patch, security
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: landergriffith+freebsdbugzilla@gmail.com
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: mfc-stable9? mfc-stable10?
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-206573-8-t0aQUPo64h@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-206573-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-206573-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Feb 2016 18:20:51 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206573

landaire <landergriffith+freebsdbugzilla@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |landergriffith+freebsdbugzi
                   |                            |lla@gmail.com

--- Comment #2 from landaire <landergriffith+freebsdbugzilla@gmail.com> ---
This bug is also present in the `aac` (not aacraid) code in the same functi=
on:

here:

/* Retrieve correct SG entries. */
if (fibsize =3D=3D (sizeof(struct aac_srb) +
           srbcmd->sg_map.SgCount * sizeof(struct aac_sg_entry))) {
        sge =3D srbcmd->sg_map.SgEntry;
        sge64 =3D NULL;
        srb_sg_bytecount =3D sge->SgByteCount;
        srb_sg_address =3D (void *)(uintptr_t)sge->SgAddress;
}

and here:

https://github.com/freebsd/freebsd/blob/bac8688b17d735d252ec75a94df67384938=
f3f9b/sys/dev/aac/aac.c#L3114-L3122

#ifdef __amd64__
else if (fibsize =3D=3D (sizeof(struct aac_srb) +
    srbcmd->sg_map.SgCount * sizeof(struct aac_sg_entry64))) {
        sge =3D NULL;
        sge64 =3D (struct aac_sg_entry64 *)srbcmd->sg_map.SgEntry;
        srb_sg_bytecount =3D sge64->SgByteCount;

        ...
}
#endif

--=20
You are receiving this mail because:
You are the assignee for the bug.=