From owner-cvs-all@FreeBSD.ORG Fri Dec 19 18:51:06 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D13316A4CE; Fri, 19 Dec 2003 18:51:06 -0800 (PST) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 73E5C43D4C; Fri, 19 Dec 2003 18:51:03 -0800 (PST) (envelope-from danfe@regency.nsu.ru) Received: from mail by mx.nsu.ru with drweb-scanned (Exim 3.35 #1 (Debian)) id 1AXXFV-0003Y6-00; Sat, 20 Dec 2003 08:53:49 +0600 Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 3.35 #1 (Debian)) id 1AXXFU-0003XU-00; Sat, 20 Dec 2003 08:53:48 +0600 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.9p2/8.12.9) with ESMTP id hBK2oR2O027502; Sat, 20 Dec 2003 08:50:27 +0600 (NOVT) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.9p2/8.12.9/Submit) id hBK2oPkU027375; Sat, 20 Dec 2003 08:50:25 +0600 (NOVT) (envelope-from danfe) Date: Sat, 20 Dec 2003 08:50:25 +0600 From: Alexey Dokuchaev To: Bruce Evans Message-ID: <20031220025025.GA21149@regency.nsu.ru> References: <20031217025641.57B6916A545@hub.freebsd.org> <20031216234544.S68813@root.org> <20031218153640.F18847@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031218153640.F18847@gamplex.bde.org> User-Agent: Mutt/1.4.1i X-Envelope-To: bde@zeta.org.au, nate@root.org, jkh@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org cc: "Jordan K. Hubbard" cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Nate Lawson Subject: Re: cvs commit: src/include regex.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Dec 2003 02:51:06 -0000 On Thu, Dec 18, 2003 at 03:49:19PM +1100, Bruce Evans wrote: > On Tue, 16 Dec 2003, Nate Lawson wrote: > > > On Tue, 16 Dec 2003, Jordan K. Hubbard wrote: > > > Modified files: > > > include regex.h > > > Log: > > > Conformance: Add REG_ENOSYS (see http://www.opengroup.org/onlinepubs/007904975/basedefs/regex.h.html) > > > > > > Revision Changes Path > > > 1.7 +1 -0 src/include/regex.h > > > > > > > > > Index: src/include/regex.h > > > diff -u src/include/regex.h:1.6 src/include/regex.h:1.7 > > > --- src/include/regex.h:1.6 Thu Oct 3 11:12:03 2002 > > > +++ src/include/regex.h Tue Dec 16 18:56:28 2003 > > > @@ -75,6 +75,7 @@ > > > #define REG_DUMP 0200 > > > > > > /* regerror() flags */ > > > +#define REG_ENOSYS -1 /* Reserved */ > > > #define REG_NOMATCH 1 > > > #define REG_BADPAT 2 > > > #define REG_ECOLLATE 3 > > > > Same. > > Not quite the same :-). This commit shares the following other bugs with > the corresponding commit to fnmatch.h: > > - missing parentheses around macro. > - abnormal comment style. The comment style in this file was perfectly > abnormal (unlike in fnmatch.h where it was normal). The new comment > matches neither, since it begins the sentence fragment with a capital > letter (like the normal style but unlike the rest of the file) and > it doesn't end the sentence fragment with a "." (unlike the normal > style but like the rest of the file). > > ... but doesn't share the following: > > - namespace pollution. There is none here since REG_ENOSYS is only > obsolescent; it is not an XSI extension. > - new macro in a section all by itself. Here it is even numerically sorted. What's really cool about Bruce is this in-depth style(9) picking. Oh I just love to see people care for perfection. 8-) 8-) ./danfe P.S. And this is actually one of the reasons FreeBSD *is* better than .