From owner-freebsd-apache@FreeBSD.ORG Sun Sep 7 15:18:23 2014 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7F1D2113; Sun, 7 Sep 2014 15:18:23 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57E1811BE; Sun, 7 Sep 2014 15:18:23 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 7E9BF11402A; Sun, 7 Sep 2014 11:18:21 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: apache 2.2 ports From: Adam Weinberger In-Reply-To: <540C764E.4060308@gmx.de> Date: Sun, 7 Sep 2014 11:18:18 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <8DF8037F-F9EC-488D-86C4-0923789C174C@adamw.org> <540C33E6.3040805@gmx.de> <4D3C03D8-2C96-46BD-B97E-590227C8FEF0@adamw.org> <540C764E.4060308@gmx.de> To: olli hauer X-Mailer: Apple Mail (2.1878.6) Cc: "apache@FreeBSD.org" , portmgr@FreeBSD.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 15:18:23 -0000 On 7 Sep, 2014, at 11:14, olli hauer wrote: > On 2014-09-07 16:59, Adam Weinberger wrote: >> On 7 Sep, 2014, at 6:31, olli hauer wrote: >>=20 >>> On 2014-09-06 17:24, Adam Weinberger wrote: >>>> apache team - >>>>=20 >>>> So it seems that setting USE_APACHE=3D22 doesn=92t actually depend = on apache-2.2. This means that every USE_APACHE=3D22 port is broken, and = as of right now won=92t have any 10.1 packages. >>>>=20 >>>> I=92m happy to go through and add "DEFAULT_VERSIONS=3D APACHE=3D22=94= to this ports, but I wanted to check with you guys first. Is that the = right way to fix it? Is there something else that can be done to make = USE_APACHE=3D22 actually depend on apache-2.2? >>>>=20 >>>=20 >>> Hi Adam, >>>=20 >>> could you give the patch below a try? >>> I've tested the patch with a small selection from = USE_APACHE=3D(22|22+|24) ports and with the patch = bsd.default-versions.mk does not overwrite the requirements. >>=20 >> That patch works perfectly for me. USE_APACHE=3D22, 22+, and 24 all = do the right thing now. >>=20 >> However, it doesn=92t check against bad values. USE_APACHE=3D42 just = drops the apache dependency altogether... most other USE_* systems put = out an error in that situation. >>=20 >> # Adam >=20 >=20 > Hi Adam, >=20 > are you sure about bad values? >=20 > Tested only with simple ports >=20 > $ cd www/mod_log_sql2 > $ sed -i.bak 's/22/42/' Makefile > $ make > =3D=3D=3D> mod_log_sql-1.101_6 : Error from bsd.apache.mk. Illegal = use of USE_APACHE ( 42+ ). > *** Error code 1 >=20 > $ cd www/blogsum > $ sed -i.bak 's/22/32/' Makefile > $ make > =3D=3D=3D> blogsum-1.1_2 is marked as broken: : Error from = bsd.apache.mk. apache24 is installed (or APACHE_PORT is defined) and = port requires apache32 at least. > *** Error code 1 >=20 >=20 > I have to admit bsd.apache.mk is not optimal, needs a major rewrite = and split into separate server / modules files. > For server bsd.apache.mk is OK but modules and other stuff should go = into a Uses/apache.mk file. Haha actually I tested it with USE_APACHE=3D32... I had no idea that was = a valid value. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org