From owner-cvs-all@FreeBSD.ORG Thu Apr 12 08:17:58 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C9E6616A406; Thu, 12 Apr 2007 08:17:58 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id BD89C13C45D; Thu, 12 Apr 2007 08:17:58 +0000 (UTC) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3C8Hw8o028654; Thu, 12 Apr 2007 08:17:58 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3C8HwQs028653; Thu, 12 Apr 2007 08:17:58 GMT (envelope-from mtm) Message-Id: <200704120817.l3C8HwQs028653@repoman.freebsd.org> From: Mike Makonnen Date: Thu, 12 Apr 2007 08:17:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/adduser adduser.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2007 08:17:58 -0000 mtm 2007-04-12 08:17:56 UTC FreeBSD src repository Modified files: usr.sbin/adduser adduser.sh Log: There are a couple of bugs in rev. 1.27: 1) The man page should describe the code, not the other way around. 2) Internal variables should not be documented or exposed, except in controlled circumstances (i.e. - That's what the -C flag is for). The variable should have been saved to the config file in save_config(). 3) The next available userid doesn't get automatically updated. The end-result is the same (user gets added with the correct uid), but in an interactive session the default uid doesn't get updated in the display. So, o Use the uidstart variable instead of uuid (bug #3) o Actually save the variable to adduser.conf (bug #2) o (bug #1 to be fixed in an upcomming commit to adduser.conf.5) MFC After: 2 weeks Revision Changes Path 1.30 +2 -7 src/usr.sbin/adduser/adduser.sh