From owner-cvs-all@FreeBSD.ORG Thu Nov 6 01:52:04 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2DDF16A4CE; Thu, 6 Nov 2003 01:52:04 -0800 (PST) Received: from mailhub.fokus.fraunhofer.de (mailhub.fokus.fraunhofer.de [193.174.154.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA5D443FDD; Thu, 6 Nov 2003 01:52:02 -0800 (PST) (envelope-from brandt@fokus.fraunhofer.de) Received: from beagle (beagle [193.175.132.100])hA69nA617107; Thu, 6 Nov 2003 10:49:11 +0100 (MET) Date: Thu, 6 Nov 2003 10:49:10 +0100 (CET) From: Harti Brandt To: Sam Leffler In-Reply-To: <200311050913.59097.sam@errno.com> Message-ID: <20031106103905.P95465@beagle.fokus.fraunhofer.de> References: <200311051147.hA5BlWiV057262@repoman.freebsd.org> <200311050913.59097.sam@errno.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/hatm if_hatm.c if_hatmvar.h [MPSAFE network] X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Hartmut Brandt List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2003 09:52:04 -0000 On Wed, 5 Nov 2003, Sam Leffler wrote: SL>On Wednesday 05 November 2003 03:47 am, Hartmut Brandt wrote: SL>> harti 2003/11/05 03:47:32 PST SL>> SL>> FreeBSD src repository SL>> SL>> Modified files: SL>> sys/dev/hatm if_hatm.c if_hatmvar.h SL>> Log: SL>> Make the driver conditionally MPSAFE. MPSAFEty defaults to not-mpsafe SL>> but can be enabled by setting hw.atm.hatmN.mpsafe in the kernel SL>> environment to a non-zero value before loading the driver. When SL>> the problems with network MPSAFEty have been sorted out this will SL>> be removed and the driver will default to MPSAFE. SL> SL>I'm about to commit mods to make debug_mpsafenet globally visible so other SL>parts of the system (to be committed) can use it too. Perhaps your stuff SL>should reference it also? The reason I did it this way is that I want to be able to set it per-interface. As soon as the IP stack works with MPSAFE drivers I'm going to remove this. I have a simulation system that has 3 ATM cards - one for connection to the outside world runs IP, the other two interface only to netgraph. I want to keep the first card non-mpsafe (obviously), but the other two mpsafe. This works just great. After fixing a problem in ng_base now the entire simulation path ATM-netgraph-ATM runs without giant on my dual-CPU system. This setup allows me to work on fixing locking issues while keeping the machine on-line. Currently I set debug_mpsafenet to true, because the driver cannot override it. For my use that's no problem, because I have not other network driver that is MPSAFE in the system. harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org