From owner-freebsd-current@FreeBSD.ORG Wed Aug 11 02:06:11 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C5471065672; Wed, 11 Aug 2010 02:06:11 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id D8F458FC14; Wed, 11 Aug 2010 02:06:10 +0000 (UTC) Received: by ewy26 with SMTP id 26so4895955ewy.13 for ; Tue, 10 Aug 2010 19:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=mXEkHxn7NjLu8bReIF8WuKtSe9bL3QuxS/sDRJ8zgYc=; b=AWAhKvsYiXTpAWqL13iWkVPeDYwtraEbSWhtESAsXLb5OMA55/MeCSJcrxIpJUVFS6 i4XJOnQXIqhZQxLmaJEGDZW50/l2VfOMGiOC4igKDMhCOH9isim6vIJynzIHne6XEu1k EXIsDw6XnGYuyDTLRgLcbFSNr9+myZG2IBcj8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=wc5wBzv/qpfGGQaHvi3oEhmUPOdRTTRTwKh8HgC7KQ8AElgvJvYaZlFDOXixFf4/Qo Sxeoh+6PK//vGhckzEiIuv6KSybQRYUY7uBKr4yhTt0VO90fKHParNHPe/nISImaTSPB JCOMvjGwTi4hqKNE4jn664YDrC/aNJObXq538= Received: by 10.213.8.200 with SMTP id i8mr12986373ebi.18.1281490875027; Tue, 10 Aug 2010 18:41:15 -0700 (PDT) Received: from localhost ([85.17.254.135]) by mx.google.com with ESMTPS id v8sm10789260eeh.2.2010.08.10.18.41.10 (version=SSLv3 cipher=RC4-MD5); Tue, 10 Aug 2010 18:41:13 -0700 (PDT) From: Anonymous To: jhell References: <4C61C50E.8040900__28807.0786548362$1281476071$gmane$org@dataix.net> <86hbj2qc0n.fsf@gmail.com> <4C61F00A.6050408@dataix.net> Date: Wed, 11 Aug 2010 05:40:52 +0400 In-Reply-To: <4C61F00A.6050408@dataix.net> (jhell@dataix.net's message of "Tue, 10 Aug 2010 20:34:18 -0400") Message-ID: <86zkwukjtn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Doug Barton , FreeBSD Stable , FreeBSD Current Subject: Re: [CFT] [sys/conf/newvers.sh] Cleanup and additions. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2010 02:06:11 -0000 jhell writes: > On 08/10/2010 19:32, Anonymous wrote: >> jhell writes: >> >>> * Adjust the paths that are checked for binaries to be of only >>> /usr/local/bin and /usr/bin. "/bin" is highly unlikely to hold svn(1), >>> git(1) or hg(1). >> >> Please, look at conf/146828. That script shouldn't blindly assume where >> user installs his packages[1]. >> >> [1] using non-default LOCALBASE is a convenient way to identify >> non-conforming ports >> > > And that would be to identify non-conforming ports using non-standard > locations. Though the option is available to look in a non-standard You're confusing default and standard value. LOCALBASE has a default for /usr/local. If it were a standard one wouldn't care about it and just hardcode /usr/local everywhere. > location for binaries, IMHO it does not belong here and I don't find > that right for building world. I also find this method a little hard to > adjust for targeting specific locations, for example if the base system > finally had a svnversion(1) installed and we prefered that over use of a > local installed port. Currently I can just subtract that path from any > one of the given SCM's configured to work with this patch without > effecting the others. Hmm, then just put LOCALBASE *after* /usr/bin in PATH. $ where grep /usr/local/bin/grep /usr/bin/grep $ find-bin grep $ echo $grep /usr/bin/grep I don't think there is a need to cater ambiguity, i.e. having different defaults for different programs. > > I have had another idea along the likes of this but just throwing an > entry point hook in that checks for the existence of a user built or > supplied file if you will so newvers.sh can keep doing what it has been > doing for all these years without the interruption for small changes > like the ones were talking about now. If people are interested in > something like this I would be more than happy to oblige and provide a > patch to do just that. While hook is a good idea without working examples for popular VCSes it'll not be very useful. One could add a script that tries to binary-search for a svn revision based on cvsup checkout, too.