From owner-svn-src-all@freebsd.org Thu Feb 14 18:22:50 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C83814DCDF7; Thu, 14 Feb 2019 18:22:50 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6150D85520; Thu, 14 Feb 2019 18:22:48 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1EIMjGW087176; Thu, 14 Feb 2019 10:22:45 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1EIMjPk087175; Thu, 14 Feb 2019 10:22:45 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902141822.x1EIMjPk087175@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344132 - head/sys/dev/ixl In-Reply-To: <201902141802.x1EI2bHA006982@repo.freebsd.org> To: Eric Joyner Date: Thu, 14 Feb 2019 10:22:45 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 6150D85520 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.95)[-0.946,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2019 18:22:50 -0000 > Author: erj > Date: Thu Feb 14 18:02:37 2019 > New Revision: 344132 > URL: https://svnweb.freebsd.org/changeset/base/344132 > > Log: > ixl: Fix panic caused by bug exposed by r344062 > > Don't use a struct if_irq for IFLIB_INTR_IOV type interrupts since that results > in get_core_offset() being called on them, and get_core_offset() doesn't > handle IFLIB_INTR_IOV type interrupts, which results in an assert() being triggered > in iflib_irq_set_affinity(). > > PR: 235730 > Reported by: Jeffrey Pieper > MFC after: 1 day Normally you would request an RE@ approval for a fast track to stable, consider this message such an approval. > Sponsored by: Intel Corporation > > Modified: > head/sys/dev/ixl/if_ixl.c > head/sys/dev/ixl/ixl_pf.h > > Modified: head/sys/dev/ixl/if_ixl.c > ============================================================================== > --- head/sys/dev/ixl/if_ixl.c Thu Feb 14 18:01:06 2019 (r344131) > +++ head/sys/dev/ixl/if_ixl.c Thu Feb 14 18:02:37 2019 (r344132) > @@ -932,7 +932,7 @@ ixl_if_msix_intr_assign(if_ctx_t ctx, int msix) > return (err); > } > /* Create soft IRQ for handling VFLRs */ > - iflib_softirq_alloc_generic(ctx, &pf->iov_irq, IFLIB_INTR_IOV, pf, 0, "iov"); > + iflib_softirq_alloc_generic(ctx, NULL, IFLIB_INTR_IOV, pf, 0, "iov"); > > /* Now set up the stations */ > for (i = 0, vector = 1; i < vsi->shared->isc_nrxqsets; i++, vector++, rx_que++) { > > Modified: head/sys/dev/ixl/ixl_pf.h > ============================================================================== > --- head/sys/dev/ixl/ixl_pf.h Thu Feb 14 18:01:06 2019 (r344131) > +++ head/sys/dev/ixl/ixl_pf.h Thu Feb 14 18:02:37 2019 (r344132) > @@ -138,7 +138,6 @@ struct ixl_pf { > struct ixl_vf *vfs; > int num_vfs; > uint16_t veb_seid; > - struct if_irq iov_irq; > }; > > /* -- Rod Grimes rgrimes@freebsd.org