From owner-freebsd-hackers@FreeBSD.ORG Thu Jul 19 10:38:32 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CDED4106566B; Thu, 19 Jul 2012 10:38:32 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe01.c2i.net [212.247.154.2]) by mx1.freebsd.org (Postfix) with ESMTP id 2AFFF8FC08; Thu, 19 Jul 2012 10:38:31 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED Received: from [84.49.175.101] (account mc467741@c2i.net HELO laptop015.hselasky.homeunix.org) by mailfe01.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 301768233; Thu, 19 Jul 2012 12:38:24 +0200 From: Hans Petter Selasky To: Doug Barton Date: Thu, 19 Jul 2012 12:38:39 +0200 User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; ) References: <5007D002.7000805@FreeBSD.org> <201207191229.52222.hselasky@c2i.net> <5007E2BA.3010300@FreeBSD.org> In-Reply-To: <5007E2BA.3010300@FreeBSD.org> X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@d2+AyewRX}mAm; Yp |U[@, _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>Y}k1C4TfysrsUI -%GU9V5]iUZF&nRn9mJ'?&>O MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201207191238.39747.hselasky@c2i.net> Cc: freebsd-hackers@freebsd.org Subject: Re: Is there a reason that xhci isn't mentioned in NOTES in 8-stable? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2012 10:38:32 -0000 On Thursday 19 July 2012 12:34:34 Doug Barton wrote: > On 07/19/2012 03:29, Hans Petter Selasky wrote: > > On Thursday 19 July 2012 11:38:11 Doug Barton wrote: > >> On 07/19/2012 02:17, Hans Petter Selasky wrote: > >>> On Thursday 19 July 2012 11:14:42 Doug Barton wrote: > >>>> The xhci code in 8-stable works, but it's not mentioned in the NOTES > >>>> files in sys/conf, sys/i386/conf, or sys/amd64/conf. The module is > >>>> hooked up in sys/modules/usb/Makefile, and that's how I've been using > >>>> it so far. Is it not possible to compile this code into the kernel? > >>>> > >>>> Doug > >>> > >>> Yes, you can compile xhci into the kernel using "device xhci". Not sure > >>> who's responsible for updating NOTES. > >> > >> That would be you. :) (Since AFAICS you added the code.) It should > >> almost certainly also be in the GENERIC files for the systems to which > >> it applies. > >> > >> In HEAD and stable/9 it's in sys/conf/NOTES, and > >> {amd64|i386}/conf/GENERIC; so the same should probably go for stable/8. > >> Not sure if the code works on stable/7 or not, but we're going to do > >> another release in stable/8 so it should be updated there for sure. > > > > I've MFC'ed the NOTES bit, but I'm not sure about the GENERIC bit. > > > > http://svn.freebsd.org/changeset/base/238616 > > Thanks! What are your concerns about adding it to GENERIC? Hi, I don't see any problems at the present. I think all issues have been ironed out including the 32/64 byte context sizes. From what I'm aware the XHCI driver in 8-stable should be the same like in 9- and 10- except from a recent patch done by mav @. This patch should not make a big difference, except for INTEL patherpoint devices. --HPS