From nobody Sun Jul 23 05:35:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R7sSS0ZLpz4nYfL; Sun, 23 Jul 2023 05:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R7sSR40qcz3xZF; Sun, 23 Jul 2023 05:35:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690090503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VCmS2ZFUrsiVfHMCjpjejTRU/ZRGdJfSKyYdJXNrU7k=; b=xl11ExNqYtkFVTEbqQQzC3kzormVitrk5AUy88us/jxuyguepn/lO5vqXa3q064wdmfHi6 FLjYOrNj19xQnS2roFmomgIue1sWhABZdCihs1TVUXHZgbubxtrrIGyVglvpe3GCy/rcEX vHgDsqWyV9bnEQfsEVqZl1jrbhtuSH92F5BRD9tn1a5Chb8i1ANFajHyJObI+CthwEbMDv AHOWOTy2xs8Xoppq8v+dl7glRoEh+wecn6gtIYcGNpsiWzQ66LjLBFgEfBGud5672y2k0I EA/FTfcl+FHXRiyw9hvFUyX1wn0f3NqfQjDJFLhexegjo0RUThrt6nLJiMF+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690090503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VCmS2ZFUrsiVfHMCjpjejTRU/ZRGdJfSKyYdJXNrU7k=; b=OQgk6WWUYhIiSsvkp3vAo7uwKYv7EJ3HYxp5WdJ8gppyeD2OlWL6JcZN422Khc5msPuXHI XN91xnsPf8+qWk1EMGbcP6AQOUq86jZ/AZ0ZGg+e4liW2INHChesFXrYKiownLOqihb8oB 5qSAaNQ2MvTbTfTUUBS7+f0b6y53+xzX1UBM7hTOG3dRHcGcKMkfHyLqD8AJQj+9ToFIDI CGsLhtkOHu/w39zHLxIw7RUCxXH8r1Bc/4GXjvIMPQtM1ZkHOib21nhp/Lmvh4N/BHqFTk 4yYMoJC0uJVDfengNFNNBg5Ltd4NgC7tUCc742M5YvDEjT10X9rutPAsPVV0Vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690090503; a=rsa-sha256; cv=none; b=RnFRt8WPxJV9pIddF4EmAKvC1rbsvUIwUDV6+gO2Gr/Z7u0YBFWhN0bcT5HhRZjOx9TG0Y 7qRByiu0N2NnvmQr2FR3OPURtA//nVzYsL1Y4K/xI6/t9mjpI6fvL3030mXDNQLxk9rI3P pPgopA/8dK2NXlnLD3aL+qvajxD8gq7SfetuJIJxm0OhzUK3isKt12eXQcHk2NE39cu4RN 04/4YfSkb2fyXpjSYpMFNy4A45xixY7pYOPj/ghEmoRSR4GqMR7rj9YVRJCT/Wfgnx3PZ6 bm+pNfFz60lCnTxcblmGoEfuElHgRYVNor2PfXDdsq4cUVCdqhszLXsTq3O7Ug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4R7sSR349tzPWT; Sun, 23 Jul 2023 05:35:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36N5Z3dE083497; Sun, 23 Jul 2023 05:35:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36N5Z3mT083496; Sun, 23 Jul 2023 05:35:03 GMT (envelope-from git) Date: Sun, 23 Jul 2023 05:35:03 GMT Message-Id: <202307230535.36N5Z3mT083496@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Cox Subject: git: 7b1e606c7222 - main - arm64 pmap: Retire PMAP_INLINE List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: alc X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7b1e606c72222acdaea613924f566ffe9b65c068 Auto-Submitted: auto-generated The branch main has been updated by alc: URL: https://cgit.FreeBSD.org/src/commit/?id=7b1e606c72222acdaea613924f566ffe9b65c068 commit 7b1e606c72222acdaea613924f566ffe9b65c068 Author: Alan Cox AuthorDate: 2023-07-22 17:55:43 +0000 Commit: Alan Cox CommitDate: 2023-07-23 05:34:17 +0000 arm64 pmap: Retire PMAP_INLINE Neither of the remaining callers to pmap_kremove() warrant inlining. Those calls rarely occur. In other words, we were optimizing for the uncommon case. MFC after: 1 week --- sys/arm64/arm64/pmap.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c index dfed0142f273..379296f375ae 100644 --- a/sys/arm64/arm64/pmap.c +++ b/sys/arm64/arm64/pmap.c @@ -170,16 +170,6 @@ __FBSDID("$FreeBSD$"); #define NUL1E (NUL0E * NL1PG) #define NUL2E (NUL1E * NL2PG) -#if !defined(DIAGNOSTIC) -#ifdef __GNUC_GNU_INLINE__ -#define PMAP_INLINE __attribute__((__gnu_inline__)) inline -#else -#define PMAP_INLINE extern inline -#endif -#else -#define PMAP_INLINE -#endif - #ifdef PV_STATS #define PV_STAT(x) do { x ; } while (0) #define __pvused @@ -2022,7 +2012,7 @@ pmap_kenter_device(vm_offset_t sva, vm_size_t size, vm_paddr_t pa) /* * Remove a page from the kernel pagetables. */ -PMAP_INLINE void +void pmap_kremove(vm_offset_t va) { pt_entry_t *pte;