Date: Sun, 23 Jul 2023 05:35:03 GMT From: Alan Cox <alc@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 7b1e606c7222 - main - arm64 pmap: Retire PMAP_INLINE Message-ID: <202307230535.36N5Z3mT083496@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by alc: URL: https://cgit.FreeBSD.org/src/commit/?id=7b1e606c72222acdaea613924f566ffe9b65c068 commit 7b1e606c72222acdaea613924f566ffe9b65c068 Author: Alan Cox <alc@FreeBSD.org> AuthorDate: 2023-07-22 17:55:43 +0000 Commit: Alan Cox <alc@FreeBSD.org> CommitDate: 2023-07-23 05:34:17 +0000 arm64 pmap: Retire PMAP_INLINE Neither of the remaining callers to pmap_kremove() warrant inlining. Those calls rarely occur. In other words, we were optimizing for the uncommon case. MFC after: 1 week --- sys/arm64/arm64/pmap.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c index dfed0142f273..379296f375ae 100644 --- a/sys/arm64/arm64/pmap.c +++ b/sys/arm64/arm64/pmap.c @@ -170,16 +170,6 @@ __FBSDID("$FreeBSD$"); #define NUL1E (NUL0E * NL1PG) #define NUL2E (NUL1E * NL2PG) -#if !defined(DIAGNOSTIC) -#ifdef __GNUC_GNU_INLINE__ -#define PMAP_INLINE __attribute__((__gnu_inline__)) inline -#else -#define PMAP_INLINE extern inline -#endif -#else -#define PMAP_INLINE -#endif - #ifdef PV_STATS #define PV_STAT(x) do { x ; } while (0) #define __pvused @@ -2022,7 +2012,7 @@ pmap_kenter_device(vm_offset_t sva, vm_size_t size, vm_paddr_t pa) /* * Remove a page from the kernel pagetables. */ -PMAP_INLINE void +void pmap_kremove(vm_offset_t va) { pt_entry_t *pte;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307230535.36N5Z3mT083496>