From owner-svn-src-all@freebsd.org Fri Aug 30 22:03:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94BA7D9C63; Fri, 30 Aug 2019 22:03:11 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46KtlL5fxNz4cYj; Fri, 30 Aug 2019 22:03:10 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-ot1-x32a.google.com with SMTP id n7so940644otk.6; Fri, 30 Aug 2019 15:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nMw7XNkA4/p00cNqHNL5Pq5Gy+S1aHYJthDnzgkucoM=; b=RmaMf6a0js/5ZPhA+N8ApOHQjx12QSVDlM7AwEmlVhZ1qUrUF3aIvHz61zK1bXAWMZ 5KCySgEpmHSa6g1Qc8t2AJodKAzzBPXD8BXwJWDIiHPa45OlugMjpeyQBLA66N1W1mlf q3OYSQQkEoHVx57ojHnk56cEp2+wZiXjXcrIEhkZgn5GMhLcAbUdMf52ohK700WcXe+n mzPwPBo19QtXaaMkiCEGL9R7PETfkDJ5pFzS24BcRt4qkEx8GCaP2yC53fRDERb+6jge /m7ZW1Q3q4HYMDEi3/MtxwpfGFXuRveBMH3usajn4Be7S2pS8R2l5MKadfHIlojT+bg8 +fPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nMw7XNkA4/p00cNqHNL5Pq5Gy+S1aHYJthDnzgkucoM=; b=jQCc64goME4sAN0Mk8rcGkaRsOAAoZUJyhoIleBe5Owa7ZncfX2cQ4kEMVPdXE4Jmx ZM2F1bDnzfHVIlDDq7m7Eg50PAUk7ltfFcm2r9tJIZPjcDlZIsXfkAziyBjEEjJRFVGA xZ+hDC+MnTCKjXrZK7kg1UbxcMiJKOjvAxiwafCuj+iwGObNRroVFwzEl3wMTZ5muZPj h2WWtbscahw4DS1/8MLDAiikEOkONXA5MuN1X3l2dYUdl6/sbDPR6jqMh/V8U5KXhxOR cGEX7jUYzM587CiLK5u23+vIuuAmO581zGFUIWy0Mg18WWd8fZtKm8rNW6rb1ZCWTVjh 9WUg== X-Gm-Message-State: APjAAAX7jCHkejZar4GR5OQsCxfi02akOmtYKKH6/HRjlFqA3GiFCMzW 9WGOhzmyWqnc+68sr6Ay2JIcXkT6R2X0y+Ifp6OYWQ== X-Google-Smtp-Source: APXvYqwshPBQXyh0XwGHA1XapoHrXxcRCShkoUE6jQwclTFWw+S5bRrJPYUGd3+f7zW/P9F5gVlxilTGQUdwhUqD254= X-Received: by 2002:a9d:7f05:: with SMTP id j5mr5429033otq.102.1567202589509; Fri, 30 Aug 2019 15:03:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:83d6:0:0:0:0:0 with HTTP; Fri, 30 Aug 2019 15:03:08 -0700 (PDT) In-Reply-To: References: <201908250511.x7P5BiPl016074@repo.freebsd.org> From: Mateusz Guzik Date: Sat, 31 Aug 2019 00:03:08 +0200 Message-ID: Subject: Re: svn commit: r351471 - in head/sys: kern sys To: Oliver Pinter Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46KtlL5fxNz4cYj X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=RmaMf6a0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2607:f8b0:4864:20::32a as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-7.71), ipnet: 2607:f8b0::/32(-2.84), asn: 15169(-2.32), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[a.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2019 22:03:11 -0000 On 8/25/19, Oliver Pinter wrote: > On Sunday, August 25, 2019, Mateusz Guzik wrote: > >> Author: mjg >> Date: Sun Aug 25 05:11:43 2019 >> New Revision: 351471 >> URL: https://svnweb.freebsd.org/changeset/base/351471 >> >> Log: >> vfs: add vholdnz (for already held vnodes) > > > Why? > > (Yes, is can read the real reason in phabricator, but the phabricator > didn't considered a persistent information in relation to commit message. > Review helper tool just comes and goes as time goes forward, but commit > messages survives the repo conversions to other VCS...) > > And once you have taken the time to write a correct description in > phabricator, it would be really really nice and helpful if you would copy > them into commit message. > I think it's a fair point that if I included this info in the review it should make it's way into the commit message. -- Mateusz Guzik