From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 20:07:56 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA8CE1065670; Thu, 15 Jan 2009 20:07:56 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 7B1298FC12; Thu, 15 Jan 2009 20:07:56 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.3/8.14.3/ALCHEMY.FRANKEN.DE) with ESMTP id n0FJmHHP078759; Thu, 15 Jan 2009 20:48:17 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.3/8.14.3/Submit) id n0FJmHFG078758; Thu, 15 Jan 2009 20:48:17 +0100 (CET) (envelope-from marius) Date: Thu, 15 Jan 2009 20:48:17 +0100 From: Marius Strobl To: John Baldwin Message-ID: <20090115194816.GA14477@alchemy.franken.de> References: <200901072152.n07Lql7h000807@svn.freebsd.org> <200901151031.42725.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901151031.42725.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186878 - head/sys/dev/mpt X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2009 20:07:57 -0000 On Thu, Jan 15, 2009 at 10:31:42AM -0500, John Baldwin wrote: > On Wednesday 07 January 2009 4:52:47 pm Marius Strobl wrote: > > Author: marius > > Date: Wed Jan 7 21:52:47 2009 > > New Revision: 186878 > > URL: http://svn.freebsd.org/changeset/base/186878 > > > > Log: > > Make the whole initiator mode part of mpt(4) endian-clean, > > specifically SPI controllers now also work in big-endian > > machines and some conversions relevant for FC and SAS > > controllers as well as support for ILP32 machines which all > > were omitted in previous attempts are now also implemented. > > The IOCTL-interface is intentionally left (and where needed > > actually changed) to be completely little-endian as otherwise > > we would have to add conversion code for every possible > > configuration page to mpt(4), which didn't seem the right > > thing to do, neither did converting only half of the user- > > interface to the native byte order. > > This change was tested on amd64 (SAS+SPI), i386 (SAS) and > > sparc64 (SAS+SPI). Due to lack of the necessary hardware > > the target mode code is still left to be made endian-clean. > > > > Reviewed by: scottl > > MFC after: 1 month > > If you wish to test the mpt_user interface on a big-endian machine you may > use //depot/jhb/raid/usr.sbin/mptutil/... > > It is likely going to need a lot of sprinkled htole*() and letoh*() though. > Thanks for the pointer! I already had looked for it but didn't manage to find it. Marius