Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Apr 2016 22:13:46 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298011 - head/sys/cam/ata
Message-ID:  <201604142213.u3EMDklN061064@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Thu Apr 14 22:13:46 2016
New Revision: 298011
URL: https://svnweb.freebsd.org/changeset/base/298011

Log:
  Add a comment about why the timeout for flush was lowered to 5s.

Modified:
  head/sys/cam/ata/ata_da.c

Modified: head/sys/cam/ata/ata_da.c
==============================================================================
--- head/sys/cam/ata/ata_da.c	Thu Apr 14 22:13:44 2016	(r298010)
+++ head/sys/cam/ata/ata_da.c	Thu Apr 14 22:13:46 2016	(r298011)
@@ -912,6 +912,11 @@ adadump(void *arg, void *virtual, vm_off
 	if (softc->flags & ADA_FLAG_CAN_FLUSHCACHE) {
 		xpt_setup_ccb(&ccb.ccb_h, periph->path, CAM_PRIORITY_NORMAL);
 
+		/*
+		 * Tell the drive to flush its intenral cache. if we
+		 * can't flush in 5s we have big problems. No need to
+		 * wait the default 60s to detect problems.
+		 */
 		ccb.ccb_h.ccb_state = ADA_CCB_DUMP;
 		cam_fill_ataio(&ccb.ataio,
 				    0,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604142213.u3EMDklN061064>