From owner-freebsd-current@FreeBSD.ORG  Sat Feb 14 09:24:53 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B6E5516A4CE; Sat, 14 Feb 2004 09:24:53 -0800 (PST)
Received: from relay.macomnet.ru (relay.macomnet.ru [195.128.64.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1C03C43D1D; Sat, 14 Feb 2004 09:24:53 -0800 (PST)
	(envelope-from maxim@macomnet.ru)
Received: from news1.macomnet.ru (o3qd26sv@news1.macomnet.ru [195.128.64.14])
	by relay.macomnet.ru (8.12.10/8.12.10) with ESMTP id i1EHOpo26050291;
	Sat, 14 Feb 2004 20:24:51 +0300 (MSK)
Date: Sat, 14 Feb 2004 20:24:51 +0300 (MSK)
From: Maxim Konovalov <maxim@macomnet.ru>
To: sos@freebsd.org
Message-ID: <20040214192736.C23696@news1.macomnet.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Sony V505BX ATA panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 17:24:53 -0000

Hi Soren,

It seems the following commit broke my Sony V505BX:

%sos         2004/01/30 11:16:08 PST
%
%  FreeBSD src repository
%
%    Modified files:
%      sys/dev/ata          ata-all.c ata-queue.c
%    Log:
%    Be more robust in the probe. We dont want to get into a loop with
%    reinitting when we try to identify devices. If they dont interrupt
%    on identify we retry once. If this fails we simply ignore that device.
%
%    Revision  Changes    Path
%    1.203     +10 -11    src/sys/dev/ata/ata-all.c
%    1.19      +28 -13    src/sys/dev/ata/ata-queue.c

It panics right after the message

ad0: 57231MB <FUJITSU MHS2060AT> [116280/16/63] at ata0-master UDMA100
ata1-slave: TIMEOUT - ATAPI_IDENTIFY no interrupt
ata1-slave: TIMEOUT - ATAPI_IDENTIFY no interrupt
acd0: CDRW <UJDA745 DVD/CDRW> at ata1-master UDMA33

A black magic below makes my notebook happy again.  Verbose boot is
there: http://news.macomnet.ru/~maxim/stuff/dmesg.boot

Index: ata-all.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
retrieving revision 1.203
diff -u -r1.203 ata-all.c
--- ata-all.c	30 Jan 2004 19:16:08 -0000	1.203
+++ ata-all.c	14 Feb 2004 15:43:20 -0000
@@ -567,7 +567,7 @@
 	    while (retries-- > 0) {
 		request->device = atadev;
 		request->timeout = 5;
-		request->retries = -1;
+		request->retries = 3;
 		request->u.ata.command = command;
 		request->flags = (ATA_R_READ | ATA_R_IMMEDIATE);
 		request->data = (caddr_t)atadev->param;
%%%

Now it boots this way:

[...]
ad0: 57231MB <FUJITSU MHS2060AT> [116280/16/63] at ata0-master UDMA100
ata1-slave: TIMEOUT - ATAPI_IDENTIFY retrying (3 retries left) LBA=0
acd0: CDRW <UJDA745 DVD/CDRW> at ata1-master UDMA33

Thanks!

-- 
Maxim Konovalov