From owner-cvs-all@FreeBSD.ORG Thu Aug 26 13:37:54 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4E0A16A4CF; Thu, 26 Aug 2004 13:37:54 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 252CC43D5D; Thu, 26 Aug 2004 13:37:54 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id B4BE8ACC62; Thu, 26 Aug 2004 15:37:52 +0200 (CEST) Date: Thu, 26 Aug 2004 15:37:52 +0200 From: Pawel Jakub Dawidek To: Roman Kurakin Message-ID: <20040826133752.GP30151@darkness.comp.waw.pl> References: <200408261242.i7QCgl7m012027@repoman.freebsd.org> <58622.1093524972@critter.freebsd.dk> <20040826131030.GO30151@darkness.comp.waw.pl> <412DE5B1.9090101@cronyx.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GJQzf4n/7sgn7z2y" Content-Disposition: inline In-Reply-To: <412DE5B1.9090101@cronyx.ru> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 13:37:54 -0000 --GJQzf4n/7sgn7z2y Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 26, 2004 at 05:29:21PM +0400, Roman Kurakin wrote: +> >Yes, I know that it should be done this way, but I'm not going to fix +> >atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else. +> >Those classes set error to 0 even when provider has not sectorsize +> >and mediasize defined. +> >=20 +> > +> Does your code print any warning message in that case? +> That could force authors of 'buggy' code to fix it. No, this should be KASSERT() inside g_error_provider(): KASSERT(error =3D=3D 0 && pp->sectorsize > 0 && pp->mediasize > 0, ("Buggy = code.")); --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --GJQzf4n/7sgn7z2y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBLeewForvXbEpPzQRAgK9AJ9e+O0ZpiP37+m8Znr7Z2QIfZ6YPACfXCnY nrabl2+yML/or5MDQJtUyE8= =Xu2F -----END PGP SIGNATURE----- --GJQzf4n/7sgn7z2y--