From owner-svn-src-user@FreeBSD.ORG Thu May 26 16:18:05 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EFF82106564A; Thu, 26 May 2011 16:18:05 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id D8A4D8FC12; Thu, 26 May 2011 16:18:04 +0000 (UTC) Received: by wyf23 with SMTP id 23so864375wyf.13 for ; Thu, 26 May 2011 09:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Gz449z3QiVj9y7Kb0EzkB5Rcpr7RQBi5bMw19Fqidc0=; b=Gn2AGlHe1HgtkXWH+3UoPojck7quLM/YB9Q7tOMFWHkwBceC2QBE/Y77zegigPf9vh MjDwwxXaPjrhPiK94FI7Og0UxWfU5M0o/TedJnD/ddDcrf+j9Y5ZYAW1B+ltzO7A4HNm QaSB0NUC7gVTD/9fWst9TTIP5Hjr0R+Zyd4QI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Q0n2Drb6CmalQqt5fCEiLRAg9UauzDMqevNzYXwU+S2ldPr7G36Zn1NfLYNY2bks8j zyKJg57GPUbqQn4x8gZer9pOT6jTttZFef9U4djiZEDX4snG+e2fG2EkbxVjdQQgIt3Q DPbssB2FvDDcM3HPG/OJ7ssQUlcMYl5pWCOCw= MIME-Version: 1.0 Received: by 10.216.141.1 with SMTP id f1mr1039402wej.35.1306426683665; Thu, 26 May 2011 09:18:03 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.93.193 with HTTP; Thu, 26 May 2011 09:18:03 -0700 (PDT) In-Reply-To: <4DDE7A36.2050104@FreeBSD.org> References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl> <4DD4243C.4070301@FreeBSD.org> <4DDD13F9.5040800@FreeBSD.org> <4DDE7555.7090500@FreeBSD.org> <4DDE7A36.2050104@FreeBSD.org> Date: Thu, 26 May 2011 09:18:03 -0700 X-Google-Sender-Auth: UFZeO5faqcCMpys_XVKVqvuEAd8 Message-ID: From: mdf@FreeBSD.org To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Attilio Rao , src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-user@freebsd.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2011 16:18:06 -0000 On Thu, May 26, 2011 at 9:05 AM, Andriy Gapon wrote: > on 26/05/2011 18:46 mdf@FreeBSD.org said the following: >> A per-thread flag is needed as long as other CPUs can be running or >> even just the scheduler on the remaining CPU. =A0So I would thing that >> flag needs to be checked until the system has been massaged to the >> state you describe above. > > I am not sure that I understand your reasoning if you mean that the flag = needs to > be checked in TD_IS_INPANIC. =A0That is, right now there is no TD_IS_INPA= NIC and > things work after panic to a certain degree. =A0I do not intend to improv= e that > degree and just want to keep an option to revert to the current state of = matters. > When TD_IS_INPANIC is introduced and stop_cpus_on_panic=3D=3D1, then ther= e will be > only one thread left running after panic, that will be the thread that ca= lled > panic, checking TDF_INPANIC just doesn't add anything. Won't the scheduler still run even if other CPUs are halted? Is there any intent to prevent switching to another thread? (I suppose this could be achieved by setting td_critnest++ and wouldn't require a flag). It's possible I misunderstood your email so my response may have been non-sensical. Thanks, matthew