From owner-cvs-all@FreeBSD.ORG Thu May 1 13:11:49 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5458537B405 for ; Thu, 1 May 2003 13:11:49 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E22A43FBD for ; Thu, 1 May 2003 13:11:47 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8966 invoked from network); 1 May 2003 20:11:53 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 1 May 2003 20:11:53 -0000 Received: from laptop.baldwin.cx ([216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h41KBhOv026715; Thu, 1 May 2003 16:11:43 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030501193258.GB778@athlon.pn.xcllnt.net> Date: Thu, 01 May 2003 16:11:48 -0400 (EDT) From: John Baldwin To: Marcel Moolenaar cc: cvs-src@FreeBSD.org cc: Nate Lawson cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/acpica acconfig.h acenv.h acfreebsd.h acgcc.h acpi.h acpiosxf.h acpixf.h acutils.h dbcmds.c dbxface.c exfldio.c exsystem.c hwsleep.c psparse.c rscreate.c tbget.c utglobal.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2003 20:11:49 -0000 On 01-May-2003 Marcel Moolenaar wrote: > On Thu, May 01, 2003 at 02:35:16PM -0400, John Baldwin wrote: >> >> > Modified files: >> > sys/contrib/dev/acpica acconfig.h acenv.h acfreebsd.h acgcc.h >> > acpi.h acpiosxf.h acpixf.h acutils.h >> > dbcmds.c dbxface.c exfldio.c exsystem.c >> > hwsleep.c psparse.c rscreate.c tbget.c >> > utglobal.c >> >> This hunk looks bogus as it didn't change during the Intel import: > *snip* >> Without this change make kernel-depend of LINT gives a _lot_ of >> warnings. LINT also doesn't compile, but this is at least a >> good first step. > > Unrelated to the change (hence removed), but related to ACPI CA > contributed code: > > There's a bug in the code that uninstalls ACPI tables. We have a > fix for this on the ia64 branch. Thanks to Peter. It's been forgotten, > but it would be nice to have this fix in as it hosed machines with > multiple SSDT tables. This is not specific to ia64. > > Of course, since this is contributed code we should get it fixed > at the source and it will find its way back to use with the next > upgrade. However, since the 0424 snapshot had problems, the first > possible upgrade would be end May, provided the problems have > been resolved. > > The question: do people think we should try to get another ACPI > snapshot in (provided we have someone willing to do it) and thus > try to get it fixed the "official" way or are we ok with changing > contrib'd code in this case and revert to the vendor branch when > we do upgrade sometime after 5.1? We have had files in ACPI land pulled off the branch before, so I think that if it's a major showstopper for 5.1 it can just be committed. I would send the patch to the acpi-jp@ list. The Intel guys follow it and are quite responsive to good bug reports and/or patches. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/