From owner-svn-src-head@freebsd.org Fri Aug 3 22:30:32 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16ECE1053732; Fri, 3 Aug 2018 22:30:32 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [198.45.61.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 99A9478645; Fri, 3 Aug 2018 22:30:31 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w73MEfCS032258 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Aug 2018 15:14:41 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id w73MEf9d032254; Fri, 3 Aug 2018 15:14:41 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Fri, 3 Aug 2018 15:14:41 -0700 From: Gleb Smirnoff To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat Message-ID: <20180803221441.GG420@FreeBSD.org> References: <201807051313.w65DDnQJ041281@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201807051313.w65DDnQJ041281@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 22:30:32 -0000 Hi Brooks, On Thu, Jul 05, 2018 at 01:13:49PM +0000, Brooks Davis wrote: B> Author: brooks B> Date: Thu Jul 5 13:13:48 2018 B> New Revision: 335979 B> URL: https://svnweb.freebsd.org/changeset/base/335979 B> B> Log: B> Make struct xinpcb and friends word-size independent. B> B> Replace size_t members with ksize_t (uint64_t) and pointer members B> (never used as pointers in userspace, but instead as unique B> idenitifiers) with kvaddr_t (uint64_t). This makes the structs B> identical between 32-bit and 64-bit ABIs. B> B> On 64-bit bit systems, the ABI is maintained. On 32-bit systems, B> this is an ABI breaking change. The ABI of most of these structs B> was previously broken in r315662. This also imposes a small API B> change on userspace consumers who must handle kernel pointers B> becoming virtual addresses. Thanks for this change. After it the anonymous unions in xinpcb, unpxb are no longer needed. Do you agree? I added them to make sizes on 32-bit and 64-bit ABIs to be identical. I prefer your new code, but didn't the unions work? Anyway, now they can be removed. -- Gleb Smirnoff