From owner-freebsd-rc@FreeBSD.ORG Wed Apr 6 14:37:48 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8E6C106564A; Wed, 6 Apr 2011 14:37:48 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6222B8FC1D; Wed, 6 Apr 2011 14:37:48 +0000 (UTC) Received: by gyg13 with SMTP id 13so674266gyg.13 for ; Wed, 06 Apr 2011 07:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=PtxwNUPYyAHgbJlG1xF4TLu1I5r04Y3QaSmFl4IWeHc=; b=OXWP7Bim94/WKBPrp/NpUg7+PJalDVKblz+zIeB9AZ6UzMaM5eiOSsusvAj/4JcSXp S3ZJjpIZpLT2awX2patro5VBgVwGbT40ojwHMrBHppdgg42AG5q6sRganVBi4JH6Gr0h Oh1j0yqhdT0UV8pbuFIqdO9jDtlY1c+OHS1Xw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=myEU58M3Jz/NpbC9/8KclIQlML5wwsnzRGJAPAk9JG0AunEL62tBcL933tqQP/1mwY pA6mCKBKUY3VhuqpuThB+/Ix+lXt5SSGTn7+J0Qnd7sZH9cFrqaX99A0BiUY1jDkZWsU ZvB8/ulUyJCsmBLZsw4behg0klOLLY6/K+Fr8= MIME-Version: 1.0 Received: by 10.236.185.129 with SMTP id u1mr539186yhm.409.1302100667255; Wed, 06 Apr 2011 07:37:47 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.103.34 with HTTP; Wed, 6 Apr 2011 07:37:47 -0700 (PDT) In-Reply-To: <4D9BEEEC.4050109@FreeBSD.org> References: <4D9BEEEC.4050109@FreeBSD.org> Date: Wed, 6 Apr 2011 10:37:47 -0400 X-Google-Sender-Auth: 4VP1zVqoCgX1sJLvcCR5oiulwTU Message-ID: From: Attilio Rao To: Doug Barton Content-Type: text/plain; charset=UTF-8 Cc: freebsd-rc@freebsd.org, Ed Maste Subject: Re: [PATCH] Adding netdumpsrv rc.d script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2011 14:37:48 -0000 2011/4/6 Doug Barton : > The rc.d script and related look fine. The only thing I'd change is a blank > line before run_rc_command (a stylistic convention). Don't forget the update > to rc.conf.5 as well. > > hope this helps, > Thanks a lot Doug. Attilio -- Peace can only be achieved by understanding - A. Einstein