From owner-svn-src-all@freebsd.org Sat Oct 31 21:31:14 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB5BD456A52; Sat, 31 Oct 2020 21:31:14 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNsmy4Yj5z40ty; Sat, 31 Oct 2020 21:31:14 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 795211CFA7; Sat, 31 Oct 2020 21:31:14 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 1A1BA27C0054; Sat, 31 Oct 2020 17:31:14 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute3.internal (MEProxy); Sat, 31 Oct 2020 17:31:14 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleejgdduheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne fuohhrthgvugcurhgvtghiphhsucdlgedtmdenfghrlhcuvffnffculddutddmnecujfgu rhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdeurhgrnhguoh hnuceuvghrghhrvghnfdcuoegsughrrghgohhnsefhrhgvvgeuufffrdhorhhgqeenucgg tffrrghtthgvrhhnpeehieeikeekffekleekleegtefgledttefghfduteeikeevfedvhf eggfffudejgfenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsughrrghgohhnodhmvghsmh htphgruhhthhhpvghrshhonhgrlhhithihqddutdegvdefheekieegqddukedutdekhedu qdgsughrrghgohhnpeephfhrvggvuefuffdrohhrghesihhmrghprdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id AF908C200A5; Sat, 31 Oct 2020 17:31:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-530-g8da6958-fm-20201021.003-g69105b13-v35 Mime-Version: 1.0 Message-Id: <47495073-df63-404d-8a3b-af2241e12f9b@www.fastmail.com> In-Reply-To: <4468e66d-2615-48a7-bdde-90f9a1266bda@www.fastmail.com> References: <202010311527.09VFRjNx098403@repo.freebsd.org> <4468e66d-2615-48a7-bdde-90f9a1266bda@www.fastmail.com> Date: Sat, 31 Oct 2020 16:30:53 -0500 From: "Brandon Bergren" To: "Brandon Bergren" , "Ed Maste" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r367209_-_in_head:_contrib/elftoolchain/readel?= =?UTF-8?Q?f_usr.bin/readelf?= Content-Type: text/plain X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 21:31:14 -0000 On Sat, Oct 31, 2020, at 3:03 PM, Brandon Bergren wrote: > This appears to have broken the build on platforms with a 32 bit > size_t, given the current state of the tinderbox. > > On Sat, Oct 31, 2020, at 10:27 AM, Ed Maste wrote: > > Author: emaste > > Date: Sat Oct 31 15:27:45 2020 > > New Revision: 367209 > > URL: https://svnweb.freebsd.org/changeset/base/367209 > > > This seems more correct to me: It's not like it could have been larger than size_t anyway, since there is no way to malloc more than that anyway. Index: contrib/elftoolchain/readelf/readelf.c =================================================================== --- contrib/elftoolchain/readelf/readelf.c (revision 367230) +++ contrib/elftoolchain/readelf/readelf.c (working copy) @@ -6909,8 +6909,8 @@ * Returns true if sucessful, false otherwise. */ static bool decompress_section(struct section *s, - unsigned char *compressed_data_buffer, uint64_t compressed_size, - unsigned char **ret_buf, uint64_t *ret_sz) + unsigned char *compressed_data_buffer, size_t compressed_size, + unsigned char **ret_buf, size_t *ret_sz) { GElf_Shdr sh;