From owner-freebsd-alpha Sun Jan 27 12:15:40 2002 Delivered-To: freebsd-alpha@freebsd.org Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) by hub.freebsd.org (Postfix) with ESMTP id 09EFF37B416 for ; Sun, 27 Jan 2002 12:15:37 -0800 (PST) Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30]) by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id PAA19661; Sun, 27 Jan 2002 15:15:36 -0500 (EST) Received: (from gallatin@localhost) by grasshopper.cs.duke.edu (8.11.6/8.9.1) id g0RKF6Z85342; Sun, 27 Jan 2002 15:15:06 -0500 (EST) (envelope-from gallatin@cs.duke.edu) From: Andrew Gallatin MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15444.24522.595616.15614@grasshopper.cs.duke.edu> Date: Sun, 27 Jan 2002 15:15:06 -0500 (EST) To: Bernd Walter Cc: freebsd-alpha@freebsd.org Subject: Re: ifconfig alignment fix In-Reply-To: <20020126181352.C75106@cicely8.cicely.de> References: <20020126181352.C75106@cicely8.cicely.de> X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Nice fix. I'm building a new kernel to test your patch now. Any idea exactly what commit introduced this problem? Drew Bernd Walter writes: > > The reason is that struct ifa_msghdr is not n * 8 bytes. > If an interface has an uneven number of addresses it toggles > alignment for the next interface. > I would be more happy when struct ifa_msghdr gets resized, > but that will break binary compatibility. > > -- > B.Walter COSMO-Project http://www.cosmo-project.de > ticso@cicely.de Usergroup info@cosmo-project.de > > --- sys/net/rtsock.c.orig Sat Jan 26 16:59:56 2002 > +++ sys/net/rtsock.c Sat Jan 26 17:00:01 2002 > @@ -664,6 +664,7 @@ > } > len += dlen; > } > + len = _ALIGN(len); > if (cp == 0 && w != NULL && !second_time) { > register struct walkarg *rw = w; > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message