From owner-svn-src-head@freebsd.org Sat Jan 27 03:32:07 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06F9CEDAE4E for ; Sat, 27 Jan 2018 03:32:07 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) Received: from sonic304-10.consmr.mail.bf2.yahoo.com (sonic304-10.consmr.mail.bf2.yahoo.com [74.6.128.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A15D173C99 for ; Sat, 27 Jan 2018 03:32:06 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) X-YMail-OSG: XjDrW3YVM1lCm4KUyF94MYSem1e1mCXVR15X0zgASNvPDYvHEpht2BQGkRIX6Dt 0Xij1TVPWiDd8xLUnVxTvu3BZe9J.4qHeCY8p75lbRNrr6fpAmd_hLGNpf8NdYmsRZAnzv4VgYrn 0hF3UcYUla_oII1E9J3wWAV_UgRrkxbYiZ8XPlASeHDwvBRE3Igqaz6y3WviBkel8.hFcRAmdeCc sATTK4pav34Gic.m_C0aFjO6Ous3YA3MfuKdfDzotfcCuXDcntP5TluthDXf44zaCGbmGljgMFcJ vCgNNsghp31C1AwDu6Lzxysq2FU.xC3BYC4YUrJ3qyBblfVPuVXvxyuldEu_OsEu6m6WmWOFajnz g5BldBasLRF4qwc34DCzPW2gS.dGO36ZkyuHM6vqTX68SWSWWo6fqOav.s.b5NonSsZrCKGvBo1q c3dTsKpCW5YWvdh3rHVClvabKQQsjrYfrC94Jhb0UhEqxo6waWUy0U4XOuj3KEzQoD7He Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Sat, 27 Jan 2018 03:32:00 +0000 Received: from smtp104.rhel.mail.bf1.yahoo.com (EHLO [192.168.1.25]) ([98.139.230.215]) by smtp407.mail.bf1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 761765f968eed0ca211c5002ac24d424 for ; Sat, 27 Jan 2018 03:31:55 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: svn commit: r328430 - head/sbin/devd Message-Id: <059B754A-3BBD-47F7-8DF4-B0277C1F385E@yahoo.com> Date: Fri, 26 Jan 2018 19:31:53 -0800 To: svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3445.5.20) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 03:32:07 -0000 Ian Lepore ian at freebsd.org wrote on Fri Jan 26 16:56:09 UTC 2018 : > Modern compilers will warn about a class with virtual functions and no > virtual dtor, so just blindly including it is more harmful than > prophylactic these days, IMO. More reliable is to have non-virtual destructors be, say, protected instead of public when possible. The language rules then lead to issues that all the C++ compilers should report violations of if a delete via a base-class pointer is attempted in the source code. I quoted a bit on the subject from the "C++ Coding Standards" book in: https://lists.freebsd.org/pipermail/svn-src-head/2018-January/108976.html === Mark Millard marklmi at yahoo.com ( markmi at dsl-only.net is going away in 2018-Feb, late)