From owner-cvs-src@FreeBSD.ORG Tue Dec 20 03:27:24 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1021) id D358716A420; Tue, 20 Dec 2005 03:27:24 +0000 (GMT) Date: Tue, 20 Dec 2005 03:27:24 +0000 From: "Christian S.J. Peron" To: Pawel Jakub Dawidek Message-ID: <20051220032724.GA12119@hub.freebsd.org> References: <200512200049.jBK0nxil048441@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200512200049.jBK0nxil048441@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2005 03:27:25 -0000 On Tue, Dec 20, 2005 at 12:49:59AM +0000, Pawel Jakub Dawidek wrote: > pjd 2005-12-20 00:49:59 UTC > > FreeBSD src repository > > Modified files: > sys/kern vfs_syscalls.c > Log: > Reduce Giant scope a bit, as fdrop() is believed to be MPSAFE. > The purpose of this change is consistency (not performance improvement:)), > as it was hard to tell if fdrop() is MPSAFE or not when I saw it sometimes > under the Giant and sometimes without it. > > Glanced at by: ssouhlal, kan > > Revision Changes Path > 1.396 +7 -9 src/sys/kern/vfs_syscalls.c Did you check to make sure that all the fo_close() operations are MP safe? I think we are safe in the common case, but we need to pay special attention to edge cases like the ones in sys/opencrypto/cryptodev.c (cryptof_close()). I am not sure that these operations are MP safe yet, in which case we might run into problems without the Giant aquisition. -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team