From owner-cvs-all Thu May 16 22:48:12 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by hub.freebsd.org (Postfix) with ESMTP id 3D27937B409 for ; Thu, 16 May 2002 22:48:07 -0700 (PDT) Received: (qmail 27631 invoked from network); 17 May 2002 05:48:05 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 17 May 2002 05:48:05 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4H5lxF73967; Fri, 17 May 2002 01:47:59 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200205170545.g4H5jdd33910@freefall.freebsd.org> Date: Fri, 17 May 2002 01:47:48 -0400 (EDT) From: John Baldwin To: John Baldwin Subject: RE: cvs commit: src/sys/alpha/include atomic.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 17-May-2002 John Baldwin wrote: > jhb 2002/05/16 22:45:39 PDT > > Modified files: > sys/alpha/include atomic.h > Log: > - Apparently, the Alpha ABI mandates that arguments be passed sign-extended > regardless of if they are signed or unsigned since it is easier to work > with sign-extended values. Thus, remove the disabled zapnot to > zero-extend the sign-extended value we read from *p in atomic_cmpset_32() > since the cmpval we are comparing against should already be > sign-extended. > - To ensure that the compiler knows to sign-extend the upper 32 bits of > cmpval rather than leaving garbage in there, cast the appropriately in > the constraints section. > > Help from: Richard Henderson According to Richard, the fact that 2.95 zero-extended the value was a bug. Oops. :-P -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message