From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Aug 7 09:10:05 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5659106566C for ; Fri, 7 Aug 2009 09:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 770058FC18 for ; Fri, 7 Aug 2009 09:10:05 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n779A5bs033612 for ; Fri, 7 Aug 2009 09:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n779A57V033611; Fri, 7 Aug 2009 09:10:05 GMT (envelope-from gnats) Resent-Date: Fri, 7 Aug 2009 09:10:05 GMT Resent-Message-Id: <200908070910.n779A57V033611@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, dikshie Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D451F1065679 for ; Fri, 7 Aug 2009 09:03:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id C42BC8FC15 for ; Fri, 7 Aug 2009 09:03:08 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n77938uX056499 for ; Fri, 7 Aug 2009 09:03:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n77938KB056498; Fri, 7 Aug 2009 09:03:08 GMT (envelope-from nobody) Message-Id: <200908070903.n77938KB056498@www.freebsd.org> Date: Fri, 7 Aug 2009 09:03:08 GMT From: dikshie To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/137510: patch for quagga X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2009 09:10:06 -0000 >Number: 137510 >Category: ports >Synopsis: patch for quagga >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Aug 07 09:10:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: dikshie >Release: FreeBSD-7.2 >Organization: Keio University >Environment: FreeBSD ipv6.ppk.itb.ac.id 7.2-STABLE FreeBSD 7.2-STABLE #56: Mon Jul 13 17:35:47 WIT 2009 dikshie@ipv6.ppk.itb.ac.id:/usr/obj/usr/src/sys/PPK i386 >Description: ospf6d bug on quagga-0.99.14. read bug #541 on quagga's bugzilla for detail. >How-To-Repeat: >Fix: patch is made by tomh at tomh dot org Patch attached with submission follows: Index: ospf6d/ospf6_lsa.c =================================================================== --- ospf6d/ospf6_lsa.c (revision 21) +++ ospf6d/ospf6_lsa.c (working copy) @@ -207,9 +207,11 @@ zlog_warn ("LSA: quagga_gettime failed, may fail LSA AGEs: %s", safe_strerror (errno)); - if (lsa->header->age >= htons (MAXAGE)) + if (ntohs (lsa->header->age) >= MAXAGE) { - /* LSA may have been prematurely aged */ + /* ospf6_lsa_premature_aging () sets age to MAXAGE; when using + relative time, we cannot compare against lsa birth time, so + we catch this special case here. */ lsa->header->age = htons (MAXAGE); return MAXAGE; } @@ -245,11 +247,6 @@ THREAD_OFF (lsa->expire); THREAD_OFF (lsa->refresh); - /* - * The below technique to age out LSA does not work when using relative time - * - memset (&lsa->birth, 0, sizeof (struct timeval)); - */ lsa->header->age = htons (MAXAGE); thread_execute (master, ospf6_lsa_expire, lsa, 0); } >Release-Note: >Audit-Trail: >Unformatted: