From owner-freebsd-testing@FreeBSD.ORG Tue Oct 15 06:23:01 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 97C09543 for ; Tue, 15 Oct 2013 06:23:01 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe005.messaging.microsoft.com [216.32.180.31]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 51851250B for ; Tue, 15 Oct 2013 06:23:00 +0000 (UTC) Received: from mail223-va3-R.bigfish.com (10.7.14.252) by VA3EHSOBE003.bigfish.com (10.7.40.23) with Microsoft SMTP Server id 14.1.225.23; Tue, 15 Oct 2013 06:22:53 +0000 Received: from mail223-va3 (localhost [127.0.0.1]) by mail223-va3-R.bigfish.com (Postfix) with ESMTP id A03BA1400C5; Tue, 15 Oct 2013 06:22:53 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.224.54; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF01-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 3 X-BigFish: VPS3(zzzz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h1082kzz1de097hz2fh2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h1155h) Received-SPF: pass (mail223-va3: domain of juniper.net designates 66.129.224.54 as permitted sender) client-ip=66.129.224.54; envelope-from=sjg@juniper.net; helo=P-EMF01-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail223-va3 (localhost.localdomain [127.0.0.1]) by mail223-va3 (MessageSwitch) id 1381818172282177_17029; Tue, 15 Oct 2013 06:22:52 +0000 (UTC) Received: from VA3EHSMHS011.bigfish.com (unknown [10.7.14.246]) by mail223-va3.bigfish.com (Postfix) with ESMTP id 40E29400049; Tue, 15 Oct 2013 06:22:52 +0000 (UTC) Received: from P-EMF01-SAC.jnpr.net (66.129.224.54) by VA3EHSMHS011.bigfish.com (10.7.99.21) with Microsoft SMTP Server (TLS) id 14.16.227.3; Tue, 15 Oct 2013 06:22:50 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF01-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Mon, 14 Oct 2013 23:21:40 -0700 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id r9F6LeL07699; Mon, 14 Oct 2013 23:21:40 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id DAD595807E; Mon, 14 Oct 2013 23:21:39 -0700 (PDT) To: Julio Merino Subject: Re: Refactoring of *.test.mk In-Reply-To: References: Comments: In-reply-to: Julio Merino message dated "Mon, 14 Oct 2013 23:24:39 -0400." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Mon, 14 Oct 2013 23:21:39 -0700 Message-ID: <20131015062139.DAD595807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-testing@freebsd.org, Rui Paulo , Garrett Cooper X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 06:23:01 -0000 Thanks Julio, looks good. One nit; in hook-atf-run.diff and hook-kyua.diff I see: +TESTS_ENV+= ATF_BUILD_CC=${DESTDIR}/usr/bin/cc etc. It would be safer to allow ATF_BUILD_CC etc to be controlled eg. TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC:U${DESTDIR}/usr/bin/cc} .. or ATF_BUILD_CC?= ${DESTDIR}/usr/bin/cc .. TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC} .. On Mon, 14 Oct 2013 23:24:39 -0400, Julio Merino writes: >[Fixing Garrett's address...]