From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 27 19:50:05 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E7E716A406 for ; Tue, 27 Feb 2007 19:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7A08713C4A5 for ; Tue, 27 Feb 2007 19:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1RJo5qC046869 for ; Tue, 27 Feb 2007 19:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1RJo5R8046868; Tue, 27 Feb 2007 19:50:05 GMT (envelope-from gnats) Resent-Date: Tue, 27 Feb 2007 19:50:05 GMT Resent-Message-Id: <200702271950.l1RJo5R8046868@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C998F16A403 for ; Tue, 27 Feb 2007 19:42:43 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from cp65.agava.net (cp65.agava.net [89.108.66.215]) by mx1.freebsd.org (Postfix) with ESMTP id 786FD13C441 for ; Tue, 27 Feb 2007 19:42:41 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from clamav by cp65.agava.net with drweb-scanned (Exim 4.44 (FreeBSD)) id 1HM8Df-00095m-2d; Tue, 27 Feb 2007 22:42:39 +0300 Received: from [213.148.29.33] (helo=nexii.panopticon) by cp65.agava.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44 (FreeBSD)) id 1HM8De-00095Z-U7; Tue, 27 Feb 2007 22:42:39 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.2]) by nexii.panopticon (Postfix) with ESMTP id 8E87717059; Tue, 27 Feb 2007 22:43:51 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 209F54122; Tue, 27 Feb 2007 22:44:19 +0300 (MSK) Message-Id: <20070227194419.209F54122@hades.panopticon> Date: Tue, 27 Feb 2007 22:44:19 +0300 (MSK) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: alexbl@FreeBSD.org Subject: ports/109640: Mk/bsd.scons.mk: add important hind for porters X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 19:50:05 -0000 >Number: 109640 >Category: ports >Synopsis: Mk/bsd.scons.mk: add important hind for porters >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Feb 27 19:50:04 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 6.1-RELEASE-p12 i386 >Organization: >Environment: System: FreeBSD hades.panopticon 6.1-RELEASE-p12 FreeBSD 6.1-RELEASE-p12 #0: Tue Jan 16 23:12:21 MSK 2007 amdmi3@hades.panopticon:/usr/obj/usr/src/sys/HADES i386 >Description: SCons does not automatically import settings affecting build (that is, CC/CXX/CFLAGS/CXXFLAGS and others) from it's parameters nor environment, and FreeBSD ports are required to respect those settings. There is a feature, though, that makes scons import all parameters given in command line to build environment easily. Judging from scons-using ports that I've seen till now, this feature is not well known, and it is not mentioned in scons manual either, so I guess it'll be wise to mention it bsd.scons.mk as easiest and fastest way to make third party SConstruct support FreeBSD ports collection and respect system compiler/flags settings. >How-To-Repeat: >Fix: --- bsd.scons.mk.patch begins here --- --- bsd.scons.mk.orig Sat Sep 16 17:32:45 2006 +++ bsd.scons.mk Tue Feb 27 22:34:37 2007 @@ -8,6 +8,17 @@ # # Please view me with 4 column tabs! +# +# Hint for porters: +# To make third party SConstruct respect everything that is passed to scons +# in SCONS_ENV (that is, most importantly, CC/CXX/CFLAGS/CXXFLAGS), just +# patch it so build Environment is constructed in this way: +# +# env = Environment(**ARGUMENTS) +# +# it may be then modified with env.Append and env.Replace +# + # Please make sure all changes to this file are passed through the maintainer. SCONS_MAINTAINER= alexbl@FreeBSD.org --- bsd.scons.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: