From owner-svn-src-head@FreeBSD.ORG  Tue Dec  1 06:48:14 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 378DB106568D;
	Tue,  1 Dec 2009 06:48:14 +0000 (UTC)
	(envelope-from green@green.homeunix.org)
Received: from green.homeunix.org (green.homeunix.org [66.92.150.152])
	by mx1.freebsd.org (Postfix) with ESMTP id DB1C58FC22;
	Tue,  1 Dec 2009 06:48:13 +0000 (UTC)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.14.3/8.14.1) with ESMTP id nB16VHk1040284;
	Tue, 1 Dec 2009 01:31:17 -0500 (EST)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.14.3/8.14.3/Submit) id nB16VGcn040283;
	Tue, 1 Dec 2009 01:31:16 -0500 (EST) (envelope-from green)
Date: Tue, 1 Dec 2009 01:31:16 -0500
From: Brian Fundakowski Feldman <green@freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
Message-ID: <20091201063116.GA35660@green.homeunix.org>
References: <200912010504.nB154VnS053167@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200912010504.nB154VnS053167@svn.freebsd.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: 
Subject: Re: svn commit: r199983 - in head: lib/libc/stdlib
	tools/regression/environ
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2009 06:48:14 -0000

On Tue, Dec 01, 2009 at 05:04:31AM +0000, Brian Feldman wrote:
> Author: green
> Date: Tue Dec  1 05:04:31 2009
> New Revision: 199983
> URL: http://svn.freebsd.org/changeset/base/199983
> 
> Log:
>   Do not gratuitously fail *env(3) operations due to corrupt ('='-less)
>   **environ entries.  This puts non-getenv(3) operations in line with
>   getenv(3) in that bad environ entries do not cause all operations to
>   fail.  There is still some inconsistency in that getenv(3) in the
>   absence of any environment-modifying operation does not emit corrupt
>   environ entry warnings.
>   
>   I also fixed another inconsistency in getenv(3) where updating the
>   global environ pointer would not be reflected in the return values.
>   It would have taken an intermediary setenv(3)/putenv(3)/unsetenv(3)
>   in order to see the change.
	^^^
I'm apparently pretty sleepy, because I had forgotten what the second half
of the change was for :P

It makes getenv(3) capable of emitting the corrupted environ warnings.
However, this is still avoided in the no-memory-allocation scenario.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\