From owner-svn-src-head@FreeBSD.ORG  Fri Oct 26 11:26:31 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 566E1216;
 Fri, 26 Oct 2012 11:26:31 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id BFC678FC12;
 Fri, 26 Oct 2012 11:26:30 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9QBQTXS011449;
 Fri, 26 Oct 2012 15:26:29 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9QBQTh7011448;
 Fri, 26 Oct 2012 15:26:29 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 26 Oct 2012 15:26:29 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Re: svn commit: r242079 - in head: sbin/ipfw share/man/man4 sys/conf
 sys/net sys/netinet sys/netinet6 sys/netpfil/ipfw
Message-ID: <20121026112629.GC70741@FreeBSD.org>
References: <201210250939.q9P9dF0q022970@svn.freebsd.org>
 <508960C2.6030003@freebsd.org> <508967E3.3070508@FreeBSD.org>
 <5089A13F.8080405@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <5089A13F.8080405@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, "Andrey V. Elsukov" <ae@FreeBSD.org>,
 svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2012 11:26:31 -0000

On Thu, Oct 25, 2012 at 10:29:51PM +0200, Andre Oppermann wrote:
A> On 25.10.2012 18:25, Andrey V. Elsukov wrote:
A> > On 25.10.2012 19:54, Andre Oppermann wrote:
A> >> I still don't agree with naming the sysctl net.pfil.forward.  This
A> >> type of forwarding is a property of IPv4 and IPv6 and thus should
A> >> be put there.  Pfil hooking can be on layer 2, 2-bridging, 3 and
A> >> who knows where else in the future.  Forwarding works only for IPv46.
A> >>
A> >> You haven't even replied to my comment on net@.  Please change the
A> >> sysctl location and name to its appropriate place.
A> >
A> > Hi Andre,
A> >
A> > There were two replies related to this subject, you did not replied to
A> > them and i thought that you became agree.
A> 
A> I replied to your reply to mine.  Other than that I didn't find
A> anything else from you.
A> 
A> > So, if not, what you think about the name net.pfil.ipforward?
A> 
A> net.inet.ip.pfil_forward
A> net.inet6.ip6.pfil_forward
A> 
A> or something like that.
A> 
A> If you can show with your performance profiling that the sysctl
A> isn't even necessary, you could leave it completely away and have
A> pfil_forward enabled permanently.  That would be even better for
A> everybody.

I'd prefer to have the sysctl. Benchmarking will definitely show
no regression, because in default case packets are tagless. But if
packets would carry 1 or 2 tags each, which don't actually belong
to PACKET_TAG_IPFORWARD, then processing would be pessimized.

-- 
Totus tuus, Glebius.