Date: Fri, 20 Feb 2015 03:14:19 +0000 From: Bruce Simpson <bms@fastmail.net> To: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r279028 - in head/usr.sbin: . ifmcstat Message-ID: <54E6A68B.1090609@fastmail.net> In-Reply-To: <201502192242.t1JMgY3e045902@svn.freebsd.org> References: <201502192242.t1JMgY3e045902@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb, Correct me if I'm wrong -- but doesn't this set of changes remove the ability for the user to see the stack-wide membership filters on each link? The implementation required KVM as it must inspect the SSM filters themselves to obtain this information. On 19/02/2015 22:42, Gleb Smirnoff wrote: > Now that IGMP and MLD sysctls provide a clean API structures that do not > leak kernel internal stuff, reconnect ifmcstat(1) back to build. The change is well motivated, but the job is only half done. The backend code you have added simply reflects the per-link information to userland as a flat data structure; it does not appear to report what the membership filters are. This would require taking a lock, walking the RB-tree for the in-mode filters, and serializing the data to userland as a variable length structure. regards Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54E6A68B.1090609>