From owner-svn-src-all@FreeBSD.ORG Fri Feb 20 03:14:22 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E4184A6B for ; Fri, 20 Feb 2015 03:14:22 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AA8C926E for ; Fri, 20 Feb 2015 03:14:22 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5661E20BE5 for ; Thu, 19 Feb 2015 22:14:20 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 19 Feb 2015 22:14:20 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.net; h= x-sasl-enc:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; s=mesmtp; bh=oq+dihRG/UBO8mtrJvFuF/vg3pQ=; b=fvr+RNIk1J3Itqag8M Vy/7gKhpJ6WrCCoyhCZ85XHjyC7pt2fdIGiwaRlcC+0FlYbJH60RQMqxJg/jS1xd kcEAtYacykRhxbhkfSacfrVpC+i/00D6pdYIMIYl/OiK/Pb0BIbh3FHvpsLQyddx 948ceLF8CGH+h8Y6sRebbphhI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:message-id:date:from :mime-version:to:subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpout; bh=oq+dihRG/UBO8mtrJvFuF/ vg3pQ=; b=SLUUD8O8+Mq2uIkioOrW/sJoxTZyz1kcP9BqdH1zcuPxdhh6CHWSx+ ZxAHYLE41hPIT5M5t0+AyCU+ro8rHfycTTqlA2kgdB/YvFhKPldYkiXhtrP7CPTB gvvMXbUUlTbdXfVa0j1FAhxAUqtDRsCY80rReuThlI7Xm9LdbqMnQ= X-Sasl-enc: prFbRgO8AM/VBpyRNNtHlw8Vdsiv3j30XhcFLXCunmZH 1424402060 Received: from [192.168.1.88] (unknown [94.194.112.120]) by mail.messagingengine.com (Postfix) with ESMTPA id E2D3C6800D5; Thu, 19 Feb 2015 22:14:19 -0500 (EST) Message-ID: <54E6A68B.1090609@fastmail.net> Date: Fri, 20 Feb 2015 03:14:19 +0000 From: Bruce Simpson User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r279028 - in head/usr.sbin: . ifmcstat References: <201502192242.t1JMgY3e045902@svn.freebsd.org> In-Reply-To: <201502192242.t1JMgY3e045902@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 03:14:23 -0000 Gleb, Correct me if I'm wrong -- but doesn't this set of changes remove the ability for the user to see the stack-wide membership filters on each link? The implementation required KVM as it must inspect the SSM filters themselves to obtain this information. On 19/02/2015 22:42, Gleb Smirnoff wrote: > Now that IGMP and MLD sysctls provide a clean API structures that do not > leak kernel internal stuff, reconnect ifmcstat(1) back to build. The change is well motivated, but the job is only half done. The backend code you have added simply reflects the per-link information to userland as a flat data structure; it does not appear to report what the membership filters are. This would require taking a lock, walking the RB-tree for the in-mode filters, and serializing the data to userland as a variable length structure. regards Bruce