From owner-svn-src-head@freebsd.org Sat Nov 14 17:26:29 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 965D7A2FCDD for ; Sat, 14 Nov 2015 17:26:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-x22e.google.com (mail-qk0-x22e.google.com [IPv6:2607:f8b0:400d:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 418B8161E for ; Sat, 14 Nov 2015 17:26:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qkda6 with SMTP id a6so3198651qkd.3 for ; Sat, 14 Nov 2015 09:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp_com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=sYiELSpiTefDOQxt48Arc0EIH9fLp4SKlLoTVZBrk+U=; b=Szy+btjXSAp/08t0YAyyA3g6oyMUIBXI+99tCm19JztyNcrfOF7uTtbkf61DygcibG VwlCGyHBnBYaoKqEyoXoHybUvmWIue1E3sTjM8xbPwN1OMtFp49I6mSOLXBxSAxXM23S hmEi4pRxq64PkW38fq+bGRsrd2xCzce/puKg5l0lUqLZ5OXKSAl3fKL86yo9Vzyznh7J CErntfASzT6rNCslCKQcnWZfpkZSlqn4OJYzy4/p3zUjSbw3bkmipPtoiNUzLjibTO/i 3/5e84Tv35I/0qY1AQz/kGRz4JRNx3r7YkSx8PMCln5+sA86aPgsnli60f8oCxBeBPbo r1ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=sYiELSpiTefDOQxt48Arc0EIH9fLp4SKlLoTVZBrk+U=; b=TaBkDDM5OmkKaaAaW+5z0ijZxIcIbqKpvYNK6vF6LyCRUIVA4ANVVMgjeaZneUUlkm MTAIdChPT6jt6v7x+wvk0b85cKb6QNH0TPq+/xyai5bVK9SI5gctfNF37fBL8mJh9lnI qI0Gz9sUJRhQqWAAvQM6m9wva0aZKE/jZVracdVvIgPSTf/dPYkPnDCUEozMbYlLEBcu jMSXGPA3Uxaeld837dE+9RKJfGvNf6F7fU1W2E3qSgGp2n83Owgf+75sJq4BpopguGRF rg4K3Am/GT0ibxAFfvfmncOFA33wWm005t0RC5TFrTze75fsrVGvai9Ey76sdSwsOdER BYhA== X-Gm-Message-State: ALoCoQnt7YygoMF7J+kUPLPtA3Hd504QPLY6xVxdjhkWj/krTiT4XK+Z0SGkUDA08MBIjs0jz16b MIME-Version: 1.0 X-Received: by 10.140.41.210 with SMTP id z76mr27754201qgz.81.1447521988328; Sat, 14 Nov 2015 09:26:28 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Sat, 14 Nov 2015 09:26:28 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <56476DD6.5010805@FreeBSD.org> References: <201511141606.tAEG61Rh062202@repo.freebsd.org> <20151114172030.7dfc24d0@bender.Home> <56476DD6.5010805@FreeBSD.org> Date: Sat, 14 Nov 2015 10:26:28 -0700 X-Google-Sender-Auth: 6C0iQglL36T-Qo7EZtBIatFS-eM Message-ID: Subject: Re: svn commit: r290821 - head/usr.sbin/ctld From: Warner Losh To: Bryan Drewery Cc: Andrew Turner , Edward Tomasz Napierala , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2015 17:26:29 -0000 On Sat, Nov 14, 2015 at 10:22 AM, Bryan Drewery wrote: > On 11/14/2015 9:20 AM, Andrew Turner wrote: > > On Sat, 14 Nov 2015 16:06:01 +0000 (UTC) > > Edward Tomasz Napierala wrote: > > > >> Author: trasz > >> Date: Sat Nov 14 16:06:01 2015 > >> New Revision: 290821 > >> URL: https://svnweb.freebsd.org/changeset/base/290821 > >> > >> Log: > >> Don't try to avoid calling free(3) with NULL argument. > > > > Why? free(NULL) is documented to be a nop and is safe to rely on this > > behaviour. > > > > You read it backwards, see the change. It's doing what you want. > Or rather, its failing to not do what you want. The double negative can be tricky :) Warner