Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Apr 2017 16:27:48 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r317094 - head/share/mk
Message-ID:  <201704181627.v3IGRmNN082877@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhb
Date: Tue Apr 18 16:27:48 2017
New Revision: 317094
URL: https://svnweb.freebsd.org/changeset/base/317094

Log:
  Disable in-tree GDB by default on x86, mips, and powerpc.
  
  GDB in ports contains all of the functionality as GDB in base
  (including kgdb) for these platforms along with additional
  functionality.  In-tree GDB remains enabled on ARM and sparc64.
  GDB in ports does not currently support kernel debugging on arm,
  and ports GDB for sparc64 has not been tested (though it does
  include sparc64 support).
  
  Reviewed by:	bdrewery, emaste, imp
  Relnotes:	yes
  Sponsored by:	DARPA / AFRL
  Differential Revision:	https://reviews.freebsd.org/D10399

Modified:
  head/share/mk/src.opts.mk

Modified: head/share/mk/src.opts.mk
==============================================================================
--- head/share/mk/src.opts.mk	Tue Apr 18 16:17:38 2017	(r317093)
+++ head/share/mk/src.opts.mk	Tue Apr 18 16:27:48 2017	(r317094)
@@ -41,7 +41,7 @@ __<src.opts.mk>__:
 # that haven't been converted over.
 #
 
-# These options are used by src the builds
+# These options are used by the src builds
 
 __DEFAULT_YES_OPTIONS = \
     ACCT \
@@ -96,7 +96,6 @@ __DEFAULT_YES_OPTIONS = \
     FTP \
     GAMES \
     GCOV \
-    GDB \
     GNU \
     GNU_DIFF \
     GNU_GREP \
@@ -263,6 +262,14 @@ __DEFAULT_NO_OPTIONS+=LLDB
 .if ${__T} == "arm" || ${__T} == "armeb"
 BROKEN_OPTIONS+=LLDB
 .endif
+# GDB in base is generally less functional than GDB in ports.  Ports GDB
+# does not yet contain kernel support for arm, and sparc64 kernel support
+# has not been tested.
+.if ${__T:Marm*} != "" || ${__T} == "sparc64"
+__DEFAULT_YES_OPTIONS+=GDB
+.else
+__DEFAULT_NO_OPTIONS+=GDB
+.endif
 # Only doing soft float API stuff on armv6
 .if ${__T} != "armv6"
 BROKEN_OPTIONS+=LIBSOFT



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704181627.v3IGRmNN082877>