Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Sep 2012 05:24:10 +0000 (UTC)
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r240881 - head/lib/libstand
Message-ID:  <201209240524.q8O5OApw050947@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevlo
Date: Mon Sep 24 05:24:10 2012
New Revision: 240881
URL: http://svn.freebsd.org/changeset/base/240881

Log:
  Revert r240850 and remove redundant NULL check before free(3).
  free(3) handles NULL parameter fine.
  
  Reviewed by:	kib, Garrett Cooper

Modified:
  head/lib/libstand/nfs.c

Modified: head/lib/libstand/nfs.c
==============================================================================
--- head/lib/libstand/nfs.c	Mon Sep 24 03:14:17 2012	(r240880)
+++ head/lib/libstand/nfs.c	Mon Sep 24 05:24:10 2012	(r240881)
@@ -606,10 +606,8 @@ nfs_open(const char *upath, struct open_
 	error = 0;
 
 out:
-	if (newfd)
-		free(newfd);
-	if (path)
-		free(path);
+	free(newfd);
+	free(path);
 #else
         currfd->iodesc = desc;
 
@@ -1256,10 +1254,8 @@ nfs_open(const char *upath, struct open_
 	error = 0;
 
 out:
-	if (newfd)
-		free(newfd);
-	if (path)
-		free(path);
+	free(newfd);
+	free(path);
 #else
 	currfd->iodesc = desc;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209240524.q8O5OApw050947>