From owner-cvs-src@FreeBSD.ORG Mon Jul 19 07:17:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 472DE16A4D6; Mon, 19 Jul 2004 07:17:08 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA3C743D3F; Mon, 19 Jul 2004 07:17:05 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.0.200] ([192.168.0.200]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i6J7N0mN052164; Mon, 19 Jul 2004 01:23:00 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <40FB7563.4080600@samsco.org> Date: Mon, 19 Jul 2004 01:16:51 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7) Gecko/20040702 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Alan Cox References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <40FB718B.7080206@samsco.org> <20040719071147.GS18577@cs.rice.edu> In-Reply-To: <20040719071147.GS18577@cs.rice.edu> X-Enigmail-Version: 0.84.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: Brian Feldman cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.csrc/sys/vm vm_contig.c vm_page.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2004 07:17:08 -0000 Alan Cox wrote: > On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote: > >>This is a pretty darn big change to something that is so vital to so >>many drivers (not including busdma, which means that this touches nearly >>every driver). Who reviewed this? Was it discussed on a public mailing >>list? What kind of testing was done for it? If you can't answer these >>questions then I'm not terribly thrilled. >> > > > I reviewed an earlier version of this and gave Brian some feedback. > > It is important to note that he added the new implementation side-by-side > with the old. By default, the old implementation is still used. So, I > wouldn't be too concerned. > > Alan Ok, I guess I missed the mention of the vm.old_contigmalloc tunable on my first reading. I'd still like to know what it has been tested on and what the future testing and maintenance requirements are. This work looks to be very interesting and beneficial, so please don't take these emails to mean that I don't like it. I'm just a bit nervous these days. Scott