Date: Tue, 23 Apr 2019 18:58:37 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Greg Lewis <glewis@eyesbeyond.com> Cc: Mathieu Arnold <mat@freebsd.org>, Greg Lewis <glewis@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r499685 - head/java/openjdk8 Message-ID: <20190423165837.zsc7awsmfh423nab@ogg.in.absolight.net> In-Reply-To: <20190423162725.GA57876@misty.eyesbeyond.com> References: <201904222052.x3MKqqVH050067@repo.freebsd.org> <20190423074622.puxd7fibzxx3xvmr@atuin.in.mat.cc> <20190423162725.GA57876@misty.eyesbeyond.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--s5xe3pvq7pely667 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 23, 2019 at 09:27:25AM -0700, Greg Lewis wrote: > On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote: > > On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote: > > > Author: glewis > > > Date: Mon Apr 22 20:52:52 2019 > > > New Revision: 499685 > > > URL: https://svnweb.freebsd.org/changeset/ports/499685 > > >=20 > > > Log: > > > Always depend on fontconfig > > > =20 > > > PR: 203862 > > > Submitted by: Dominik Lisiak <dominik.lisiak@bemsoft.pl> > >=20 > > You need to bump PORTREVISION when you change the runtime dependencies. >=20 > I didn't bump it since this is a build fix. I.e., we fail the configure > step without the dependency. If that still requires a PORTREVISION bump > then I think the porters handbook could use with some clarification on > the topic. Then it does not, but nothing in the commit message could give any hint that it was fixing the build, and not simply registering a dependency correctly.=20 --=20 Mathieu Arnold --s5xe3pvq7pely667 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAly/RDxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkisMQ//XMg4Yx+FFFfpWht5w6Cx8fkOhoSg6iOPTkF+bl8G7yvYZeSldJ8sa5nZ T7YlrDtrBfSGPqgjWIHSNwXwW5oBcQ8IniqRLOzofvoi1vsrAU915jRZPZBk55WN rWNSTMhTcakNdvbeevPDyroTVqahDqEWkz6LPwXikAqgNDTAAZyVcqL1iKghTSiq scPRhrvXvPP5105coYwYRwDdGZ+pL2xylz6gSE3jelbBo/fAHTjbCX1m7VPRx8+o IJkO3+IinHYIFggGkt3cuxI5UiK0a2CSVSxM/kH0pPh0E9lafDiiuOTzqbs3GUNc ABX6uuddw1G8+KTgXzulrS4cFW7D+g7lz+tE4YYwpQHy4Lca9hCcEGsv3Z2nplAt Re2R2R4bT7J0KYVZL6tmOOgYDWYF7Pb8e93AXxcGLP7pM3tu/kbswGGA5Bfdj0JN y6/OFedOMWbii6LgNpHfWPVl8Q8pmQqfB6JE3FywqTBpIEJl6xpnnNm+Tsa/KSC0 1wGg+g5Wx06ri9CL2KrIEajeRa5vbGc5tQDK+XpLXvzlJZtrjrTWSoYJegotMZ2T kONwYUd/0evcaXKyDUYsEAY9Od9Jjc1YBYHMiteeG3J+W4JsXj1i+RRH+N77Dr5X Sj1brsNjtvceUAH2fQE6GsjHHBw4nMaJQwUNDA26Df48FQk3fXQ= =uUiz -----END PGP SIGNATURE----- --s5xe3pvq7pely667--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190423165837.zsc7awsmfh423nab>